Bug 240691 - games/starfighter: fix build on GCC architectures
Summary: games/starfighter: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-19 16:23 UTC by Piotr Kubaj
Modified: 2019-09-21 15:24 UTC (History)
1 user (show)

See Also:
asiciliano: maintainer-feedback+
koobs: merge-quarterly?

Attachments
patch (313 bytes, patch)
2019-09-19 16:23 UTC, Piotr Kubaj 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-09-19 16:23:34 UTC 
Created attachment 207629 [details]
patch

Set USE_CSTD=c99 to fix build issue when using base GCC:
gfx.c:922: error: 'for' loop initial declaration used outside C99 mode
Comment 1 Alfonso S. Siciliano freebsd_committer freebsd_triage 2019-09-19 19:38:19 UTC 
It' ok, you could commit,
thanks
Comment 2 Alfonso S. Siciliano freebsd_committer freebsd_triage 2019-09-19 19:38:41 UTC 
Comment on attachment 207629 [details]
patch

ok
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-20 08:26:22 UTC 
^Triage: Reporter is committer, MAINTAINER is not committer, assign accordingly
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-20 08:26:52 UTC 
Comment on attachment 207629 [details]
patch

^Triage: Build fixes are:

Approved by: portmgr (blanket: build fix) and don't require maintainer approval
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-09-21 15:24:18 UTC 
A commit references this bug:

Author: pkubaj
Date: Sat Sep 21 15:23:33 UTC 2019
New revision: 512512
URL: https://svnweb.freebsd.org/changeset/ports/512512

Log:
  games/starfighter: fix build on GCC architectures

  Set USE_CSTD=c99 to fix build issue when using base GCC:
  gfx.c:922: error: 'for' loop initial declaration used outside C99 mode

  PR:		240691
  Approved by:	portmgr (blanket: build fix), linimon (mentor)
  Differential Revision:	https://reviews.freebsd.org/D21722

Changes:
  head/games/starfighter/Makefile