Bug 240707 - ports-mgmt/portal: fix build on GCC architectures
Summary: ports-mgmt/portal: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Frederic Culot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-20 11:11 UTC by Piotr Kubaj
Modified: 2019-12-22 19:24 UTC (History)
1 user (show)

See Also:
culot: maintainer-feedback+

Attachments
patch (798 bytes, patch)
2019-09-20 11:11 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (culot)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-09-20 11:11:02 UTC 
Created attachment 207647 [details]
patch

Only add -L${NCURSESLIB} when ${NCURSESLIB} isn't /usr/lib to prevent linking with base libstdc++ on GCC architectures.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-09-20 16:39:02 UTC 
Approved as mentor pending maintainer review.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-09-30 14:23:31 UTC 
A commit references this bug:

Author: pkubaj
Date: Mon Sep 30 14:22:54 UTC 2019
New revision: 513387
URL: https://svnweb.freebsd.org/changeset/ports/513387

Log:
  net/sems: fix build on big-endian architectures

  This port needs C++11 compiler:
  cc1plus: error: unrecognized command line option "-std=c++11"

  Additionally, it needs appropriate definitions for big-endian architectures:
  /usr/local/poudriere/ports/default/net/sems/work/sems-7400051/core/plug-in/isac/libisac/typedefs.h:80:2: error: #error Please add support for your architecture in typedefs.h
     80 | #error Please add support for your architecture in typedefs.h
        |  ^~~~~

  PR:		240707
  Approved by:    nwhitehorn (maintainer), linimon (mentor)

Changes:
  head/net/sems/Makefile
  head/net/sems/files/patch-core_plug-in_isac_libisac_typedefs.h
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-12-22 19:24:53 UTC 
A commit references this bug:

Author: pkubaj
Date: Sun Dec 22 19:23:51 UTC 2019
New revision: 520653
URL: https://svnweb.freebsd.org/changeset/ports/520653

Log:
  ports-mgmt/portal: fix build on GCC architectures

  Only add -L${NCURSESLIB} when ${NCURSESLIB} isn't /usr/lib to prevent linking with base libstdc++ on GCC architectures.

  PR:		240707
  Approved by:	culot (maintainer)

Changes:
  head/ports-mgmt/portal/Makefile