Bug 240749 - x11/lumina: Update to 1.5.0
Summary: x11/lumina: Update to 1.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-22 12:13 UTC by Loïc Bartoletti
Modified: 2019-09-24 17:01 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback+


Attachments
lumina-1.5.0 (131.65 KB, patch)
2019-09-22 16:18 UTC, Loïc Bartoletti
no flags Details | Diff
patch (136.09 KB, patch)
2019-09-22 17:05 UTC, Kurt Jaeger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti 2019-09-22 12:13:23 UTC
x11/lumina: Update to 1.5.0

 * Remove deskutils/lumina-notify (upstreamed) [1]
 * Remove deskutils/lumina-xdg-entry (upstreamed) [1]
 * Fix variables order (pet portlint)
 * Alphabetize USE_QT
 * Update knob to use options helpers
 * Remove GH_TAGNAME (except for deskutils/lumina-pdf and deskutils/lumina-calculator which haven't release tag)
 * Change GH_ACCOUNT from "trueos" to "lumina-desktop"
 * Add a new port deskutils/lumina-photo
 * Change I18N option to well know NLS option

 Changelog:

   AFAIK there is not an explicit changelog.


 [1] https://github.com/lumina-desktop/lumina/commit/89ad0095d7da09158778b5afae9beeaa0bd98d38
 [2] https://github.com/lumina-desktop/lumina/commit/0069a052e1cbef588e8f93a31314965b0c2af68a

QA:

  * portlint: OK (looks fine.)
  * testport: OK (poudriere: 11 12 HEAD, i386 amd64)
  * I use it on my machine (12 amd64)

The patch is available for a review in phabricator:
https://reviews.freebsd.org/D21749
Comment 1 Kurt Jaeger freebsd_committer 2019-09-22 16:11:23 UTC
Is there a chance that you generate a single diff against the port tree ?

Otherwise it means dissecting the raw downloaded diff in approx. 10 separate
files and applying it manually. That is error-prone.
Comment 2 Loïc Bartoletti 2019-09-22 16:18:14 UTC
Created attachment 207720 [details]
lumina-1.5.0
Comment 3 Loïc Bartoletti 2019-09-22 16:21:39 UTC
(In reply to Kurt Jaeger from comment #1)
Done
Comment 4 Kurt Jaeger freebsd_committer 2019-09-22 17:05:20 UTC
Created attachment 207723 [details]
patch

I prepared a svn diff from the review-diff, because this seems to be easier to test && apply.
Comment 5 Kurt Jaeger freebsd_committer 2019-09-22 17:06:25 UTC
Comment on attachment 207723 [details]
patch

Ups, so I was too hasty.
Comment 6 Kurt Jaeger freebsd_committer 2019-09-22 17:29:49 UTC
testbuilds@work
Comment 7 Kurt Jaeger freebsd_committer 2019-09-22 18:23:43 UTC
testbuilds on cur-amd64, 12.0-amd64, 11.3-amd64, cur-i386 all fine.
Comment 8 Kurt Jaeger freebsd_committer 2019-09-24 16:34:29 UTC
approval from maintainer per mail
Comment 9 Kurt Jaeger freebsd_committer 2019-09-24 16:41:17 UTC
Committed, thanks!
Comment 10 commit-hook freebsd_committer 2019-09-24 16:41:29 UTC
A commit references this bug:

Author: pi
Date: Tue Sep 24 16:41:04 UTC 2019
New revision: 512720
URL: https://svnweb.freebsd.org/changeset/ports/512720

Log:
  x11/lumina: upgrade 1.4.1 -> 1.5.0

  - Remove deskutils/lumina-notify (upstreamed)
    https://github.com/lumina-desktop/lumina/commit/89ad0095d7da09158778b5afae9beeaa0bd98d38
  - Remove deskutils/lumina-xdg-entry (upstreamed)
    https://github.com/lumina-desktop/lumina/commit/0069a052e1cbef588e8f93a31314965b0c2af68a
  - Fix variables order (pet portlint)
  - Alphabetize USE_QT
  - Update knob to use options helpers
  - Remove GH_TAGNAME (except for deskutils/lumina-pdf and
    deskutils/lumina-calculator which haven't release tag)
  - Change GH_ACCOUNT from "trueos" to "lumina-desktop"
  - Add a new port deskutils/lumina-photo
  - Change I18N option to well know NLS option

  PR:		240749
  Submitted by:	Loic Bartoletti <lbartoletti@tuxfamily.org>
  Approved by:	JT Pennington <jt@ixsystems.com> (maintainer)
  Differential Revision:	D21749

Changes:
  head/MOVED
  head/deskutils/Makefile
  head/deskutils/lumina-archiver/Makefile
  head/deskutils/lumina-archiver/distinfo
  head/deskutils/lumina-archiver/pkg-plist
  head/deskutils/lumina-calculator/Makefile
  head/deskutils/lumina-calculator/distinfo
  head/deskutils/lumina-calculator/pkg-plist
  head/deskutils/lumina-fileinfo/Makefile
  head/deskutils/lumina-fileinfo/distinfo
  head/deskutils/lumina-fm/Makefile
  head/deskutils/lumina-fm/distinfo
  head/deskutils/lumina-fm/pkg-plist
  head/deskutils/lumina-mediaplayer/Makefile
  head/deskutils/lumina-mediaplayer/distinfo
  head/deskutils/lumina-mediaplayer/pkg-plist
  head/deskutils/lumina-pdf/Makefile
  head/deskutils/lumina-pdf/distinfo
  head/deskutils/lumina-pdf/pkg-descr
  head/deskutils/lumina-pdf/pkg-plist
  head/deskutils/lumina-photo/
  head/deskutils/lumina-photo/Makefile
  head/deskutils/lumina-photo/distinfo
  head/deskutils/lumina-photo/pkg-descr
  head/deskutils/lumina-photo/pkg-plist
  head/deskutils/lumina-screenshot/Makefile
  head/deskutils/lumina-screenshot/distinfo
  head/deskutils/lumina-screenshot/pkg-plist
  head/deskutils/lumina-textedit/Makefile
  head/deskutils/lumina-textedit/distinfo
  head/deskutils/lumina-textedit/pkg-plist
  head/x11/lumina/Makefile
  head/x11/lumina-core/Makefile
  head/x11/lumina-core/distinfo
  head/x11/lumina-core/pkg-plist
  head/x11/lumina-coreutils/Makefile
  head/x11/lumina-coreutils/distinfo
  head/x11/lumina-coreutils/pkg-plist
Comment 11 commit-hook freebsd_committer 2019-09-24 17:01:33 UTC
A commit references this bug:

Author: pi
Date: Tue Sep 24 17:00:32 UTC 2019
New revision: 512723
URL: https://svnweb.freebsd.org/changeset/ports/512723

Log:
  x11/lumina: fix build on gcc platforms, re-adding USES=compiler:c++11-lang

  - and deleting the two ports I should have deleted in the previous commit

  PR:		240749
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/deskutils/lumina-calculator/Makefile
  head/deskutils/lumina-fm/Makefile
  head/deskutils/lumina-notify/
  head/deskutils/lumina-pdf/Makefile
  head/deskutils/lumina-xdg-entry/