Bug 240778 - lacking support for Lenovo Thinkpad T490
Summary: lacking support for Lenovo Thinkpad T490
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.0-RELEASE
Hardware: amd64 Any
: --- Affects Some People
Assignee: Oleksandr Tymoshenko
URL:
Keywords:
Depends on: 229120
Blocks:
  Show dependency tree / graph
 
Reported: 2019-09-23 17:54 UTC by Ulrich Spörlein
Modified: 2019-10-16 15:59 UTC (History)
2 users (show)

See Also:

Attachments
acpidump -dt (gzipped, otherwise 1.5MB) (138.23 KB, application/gzip)
2019-09-23 17:55 UTC, Ulrich Spörlein 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Spörlein freebsd_committer freebsd_triage 2019-09-23 17:54:17 UTC 
Hi

misc/229120 added some tweaks for newer models, but didn't do much for my T490.

As requested, I'm adding an acpidump -dt.

Not working:
- neither acpi_ibm nor acpi_video attach so display brightness can't be changed
- wifi is not working, but there's bug #227044 for that already
- sound isn't working
- evdev support would be nice, but that PR should live somewhere else
Comment 1 Ulrich Spörlein freebsd_committer freebsd_triage 2019-09-23 17:55:17 UTC 
Created attachment 207746 [details]
acpidump -dt (gzipped, otherwise 1.5MB)
Comment 2 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-09-23 22:37:17 UTC 
(In reply to Ulrich Spoerlein from comment #1)

Thanks for submitting acpidump output. Looks like it should be supported by the Ali's changes in bug #229120. I didn't notice you were talking about 12.0-RELEASE in your original message. Commit 347636 didn't make it to 12.0-RELEASE but should be part of 12.1. You can try to build acpi_ibm from stable/12 and check if it fixes the issue:

cd sys/modules/acpi/acpi_ibm
make
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-25 02:53:08 UTC 
Pending feedback from reporter
Comment 4 Ulrich Spörlein freebsd_committer freebsd_triage 2019-10-16 15:59:36 UTC 
Urgh, I'm so sorry folks. I was 100% sure that I had updated the system to 12-STABLE. Turns out I was mistaken. :(

After the update to 12.1-STABLE the audio driver attaches, as well as acpi_ibm. I probably need a new i915kms module, as it crashes on load, but my poudriere box is lagging behind.

Sorry for the noise :(

Wifi is of course still blocked on bug #227044 though.