Bug 240875 - usr.sbin/sysrc: If the file to be modified does not exist, an error message is displayed
Summary: usr.sbin/sysrc: If the file to be modified does not exist, an error message i...
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-rc mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-09-27 15:02 UTC by Jose Luis Duran
Modified: 2019-12-02 05:33 UTC (History)
1 user (show)

See Also:


Attachments
sysrc.subr patch obtained from https://github.com/freebsd/poudriere/pull/708#issuecomment-526753174 (441 bytes, patch)
2019-09-27 15:02 UTC, Jose Luis Duran
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Luis Duran 2019-09-27 15:02:24 UTC
Created attachment 207890 [details]
sysrc.subr patch obtained from https://github.com/freebsd/poudriere/pull/708#issuecomment-526753174

Currently, with sysrc, if the file to be modified does not exist, an error message is displayed.

In this case, there is no /etc/rc.conf:

    root@test:~ # sysrc hostname="test.example.com"
    awk: can't open file /etc/rc.conf
     source line number 1
    hostname:  -> test.example.com

The patch fixes this situation.

This patch was created by @dteske, obtained from https://github.com/freebsd/poudriere/pull/708#issuecomment-526753174
Comment 1 commit-hook freebsd_committer 2019-12-02 05:24:30 UTC
A commit references this bug:

Author: dteske
Date: Mon Dec  2 05:24:17 UTC 2019
New revision: 355280
URL: https://svnweb.freebsd.org/changeset/base/355280

Log:
  Fix spurious error from sysrc

  When using sysrc to modify a file, the file should be created silently.
  However, with the introduction of SVN r335280, an error of "No such file
  or directory" would appear despite everything else working as-expected.

  The nature of this spurious error is that SVN r335280 did not check if
  the file exists first, before trying to fixup the line-endings in the
  file just prior to modification.

  PR:		bin/240875
  Reported by:	Jose Luis Duran
  MFC after:	3 days

Changes:
  head/usr.sbin/bsdconfig/share/sysrc.subr