Bug 241026 - graphics/cimg: fix build on non-x86
Summary: graphics/cimg: fix build on non-x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-02 20:08 UTC by Piotr Kubaj
Modified: 2019-10-03 19:16 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (thierry)


Attachments
patch (2.00 KB, patch)
2019-10-02 20:08 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (thierry)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-10-02 20:08:26 UTC
Created attachment 208047 [details]
patch

CImg.h assumes signed char, make it signed explicitly.

-mtune=generic doesn't exist on e.g. powerpc64.

USES=compiler:c11 is necessary.
Comment 1 Thierry Thomas freebsd_committer 2019-10-03 19:15:12 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2019-10-03 19:16:11 UTC
A commit references this bug:

Author: thierry
Date: Thu Oct  3 19:15:14 UTC 2019
New revision: 513712
URL: https://svnweb.freebsd.org/changeset/ports/513712

Log:
  Make buildable on non-x86 architecture:

  - CImg.h assumes signed char, make it signed explicitly.

  - -mtune=generic doesn't exist on e.g. powerpc64.

  - USES=compiler:c11 is necessary.

  PR:		241026
  Submitted by:	pkubaj

Changes:
  head/graphics/cimg/Makefile
  head/graphics/cimg/files/patch-CImg.h
  head/graphics/cimg/files/patch-examples__Makefile