Bug 241095 - net-p2p/transmission-cli: Drop defunct WOLFSSL option
Summary: net-p2p/transmission-cli: Drop defunct WOLFSSL option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
Keywords: needs-qa
Depends on:
Reported: 2019-10-06 07:48 UTC by Tobias Kortkamp
Modified: 2019-10-18 20:09 UTC (History)
1 user (show)

See Also:
rigoletto: maintainer-feedback+

transmission-cli.diff (1.06 KB, patch)
2019-10-06 07:48 UTC, Tobias Kortkamp
tobik: maintainer-approval? (rigoletto)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-10-06 07:48:24 UTC
Created attachment 208132 [details]

There is no opt_CMAKE_ARGS helper, so WOLFSSL_CMAKE_ARGS and
OPENSSL_CMAKE_ARGS do nothing.  In CMakeLists.txt WITH_CRYPTO
defaults to "openssl".  With WOLFSSL=on the port is still linked
to OpenSSL since -DWITH_CRYPTO=cyassl is never passed to the build.
This is obviously not what is wanted.

Problem is that even when that is fixed building with WOLFSSL support
is broken due to missing enabled RC4 support in security/wolfssl
(cf, bug #207664).  This has not been addressed in over 3 years
now.  I think it might be time to just remove the complication from
transmission-cli altogether and not pretend there is functional
WolfSSL support.

Attached patch removes the OPENSSL and WOLFSSL options and makes
use of OpenSSL mandatory.  It also drops LITE_CONFIGURE_ENABLE which
does not make sense in a USES=cmake based port.

I have only tested building transmission-cli and not the slave
ports so this will need more QA.
Comment 1 Alexandre C. Guimarães freebsd_committer 2019-10-07 23:32:23 UTC
I was willing to just touch this port again when the v3.0 version come out (and I will need to do some changes). :-D
Comment 2 Alexandre C. Guimarães freebsd_committer 2019-10-07 23:42:45 UTC
I will have a look on it tomorrow, but for starters (IIRC) ssl shouldn't be on the "general" USES because transmission-web doesn't need it.

Thank you.
Comment 3 Tobias Kortkamp freebsd_committer 2019-10-08 05:06:37 UTC
(In reply to Alexandre C. Guimarães from comment #2)
USES=ssl is under .if ${SLAVEPORT:Nweb} so it should not affect transmission-web.
Comment 4 commit-hook freebsd_committer 2019-10-17 18:01:36 UTC
A commit references this bug:

Author: rigoletto
Date: Thu Oct 17 18:01:21 UTC 2019
New revision: 514668
URL: https://svnweb.freebsd.org/changeset/ports/514668

  net-p2p/transmission-cli: Drop defunct WOLFSSL option.

  - drop LITE_CONFIGURE_ENABLE, a remnant before switching to cmake

  PR:		241095
  Submitted by:	tobik
  Approved by:	tcberner (mentor)

Comment 5 Alexandre C. Guimarães freebsd_committer 2019-10-17 18:02:51 UTC

Thank you and sorry about the delay.
Comment 6 Tobias Kortkamp freebsd_committer 2019-10-18 14:36:07 UTC
Thank you.