Bug 241135 - emulators/bsvc: Upgrade to latest upstream (v2.4.3).
Summary: emulators/bsvc: Upgrade to latest upstream (v2.4.3).
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-08 19:25 UTC by Dan Cross
Modified: 2019-10-24 15:18 UTC (History)
0 users

See Also:


Attachments
Patch from current emulators/bsvc to latest. Note that many files are deleted. (17.61 KB, patch)
2019-10-08 19:25 UTC, Dan Cross
no flags Details | Diff
Port patch file: note, many files have been deleted. (17.59 KB, patch)
2019-10-15 13:30 UTC, Dan Cross
no flags Details | Diff
Port patch file including pkg-plist. (18.28 KB, patch)
2019-10-23 16:18 UTC, Dan Cross
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Cross 2019-10-08 19:25:15 UTC
Created attachment 208180 [details]
Patch from current emulators/bsvc to latest. Note that many files are deleted.

Upgrade emulators/bsvc to version 2.4.3, which is the upstream latest. This fixes many bugs in the former (ancient) version which, while it perhaps compiled, probably didn't work. In particular, it obsoletes all of the patches previously included with the port. This version works well enough to run an ersatz port of Comer's Xinu teaching system that I did, based on the original for the PDP-11.

Also add myself as the maintainer, as I am the upstream maintainer.

Incidentally, I'm also the original porter. I left my old email address at the top of the Makefile -- that felt kind of meta.
Comment 1 Dmitry Marakasov freebsd_committer 2019-10-14 17:58:05 UTC
- Please reorder Makefile statements according to portlint(1) (DISTVERSIONPREFIX goes before DISTVERSION, everything else after USES)
- Please add LICENSE and WWW
- You probably need to set USE_CSTD/USE_CXXSTD, otherwise -std compiler args are lost which may lead to build failures with some compilers
- You don't need to set GH_PROJECT as it already defaults to PORTNAME
- Installation is broken, DESTDIR is not respected

===>  Staging for bsvc-2.4.3
===>   Generating temporary packing list
gmake[1]: Entering directory '/wrkdirs/usr/ports/emulators/bsvc/work/bsvc-2.4.3/src'
mkdir -p /usr/local/bin /usr/local/lib/bsvc
mkdir: /usr/local/lib/bsvc: Permission denied
gmake[1]: *** [GNUMakefile.common:115: install] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/emulators/bsvc/work/bsvc-2.4.3/src'
*** Error code 2
Comment 2 Dan Cross 2019-10-15 13:30:40 UTC
Created attachment 208327 [details]
Port patch file: note, many files have been deleted.

This is the latest patch file for port emulators/bsvc: it updates the older port to the latest upstream version, deleting many files.
Comment 3 Dan Cross 2019-10-15 13:31:37 UTC
(In reply to Dmitry Marakasov from comment #1)

Thank you for the detailed response. Comments have been addressed, and a new patch uploaded.

> - Please reorder Makefile statements according to portlint(1) (DISTVERSIONPREFIX goes before DISTVERSION, everything else after USES)

Done.

> - Please add LICENSE and WWW

Done.

> - You probably need to set USE_CSTD/USE_CXXSTD, otherwise -std compiler args are lost which may lead to build failures with some compilers

Done.

> - You don't need to set GH_PROJECT as it already defaults to PORTNAME

Removed.

> - Installation is broken, DESTDIR is not respected

Done upstream.
Comment 4 Dmitry Marakasov freebsd_committer 2019-10-23 16:08:15 UTC
Looks good, however, pkg-plist seem to be missing.

PS. When updating the patch, please obsolete older patches to avoid confusion.
Comment 5 Dan Cross 2019-10-23 16:18:37 UTC
Created attachment 208531 [details]
Port patch file including pkg-plist.

Latest BSVC patch, including pkg-plist and obsoleting the previous two patches.
Comment 6 Dan Cross 2019-10-23 16:19:28 UTC
(In reply to Dmitry Marakasov from comment #4)
> Looks good, however, pkg-plist seem to be missing.

My bad; updated patch including pkg-plist uploaded.

> PS. When updating the patch, please obsolete older patches to avoid confusion.

Done; thanks for the tip.
Comment 7 commit-hook freebsd_committer 2019-10-24 15:18:10 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Oct 24 15:18:02 UTC 2019
New revision: 515344
URL: https://svnweb.freebsd.org/changeset/ports/515344

Log:
  - Update emulators/bsvc to 2.4.3
  - Modernize port
  - Pass maintainership to submitter

  PR:		241135
  Submitted by:	cross@gajendra.net

Changes:
  head/emulators/bsvc/Makefile
  head/emulators/bsvc/distinfo
  head/emulators/bsvc/files/
  head/emulators/bsvc/pkg-descr
  head/emulators/bsvc/pkg-plist