Bug 241144 - mail/dovecot: Fails to package with LUA=OFF
Summary: mail/dovecot: Fails to package with LUA=OFF
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Larry Rosenman
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-10-09 07:57 UTC by Matthias Pfaller
Modified: 2019-10-09 18:13 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (ler)
koobs: merge-quarterly?

Attachments
Fix packaging when Lua is not enabled. (595 bytes, patch)
2019-10-09 08:12 UTC, Ralf van der Enden 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Pfaller 2019-10-09 07:57:13 UTC 
no longer installs when lua is not enabled:

pkg-static: Unable to access file /construction/xports/mail/dovecot/work/stage/usr/local/%%LUA_LIBDIR%%exec/dovecot/health-check.sh:No such file or directory
*** Error code 1
Comment 1 Ralf van der Enden 2019-10-09 08:12:27 UTC 
Created attachment 208191 [details]
Fix packaging when Lua is not enabled.
Comment 2 Marek 2019-10-09 09:31:13 UTC 
Changed pkg-plist file fixed building when Lua is disabled. Thx @Ralf van der Enden
Comment 3 Larry Rosenman freebsd_committer freebsd_triage 2019-10-09 14:04:44 UTC 
Committed, thanks.
Comment 4 Larry Rosenman freebsd_committer freebsd_triage 2019-10-09 14:11:18 UTC 
pre-mature closing....
re-opening whilst I test.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2019-10-09 14:26:43 UTC 
(In reply to Larry Rosenman from comment #4)
Patch work for me: dovecot without LUA.
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-10-09 14:39:33 UTC 
A commit references this bug:

Author: ler
Date: Wed Oct  9 14:38:33 UTC 2019
New revision: 514164
URL: https://svnweb.freebsd.org/changeset/ports/514164

Log:
  mail/dovecot: fix breakage when LUA is NOT selected.

  PR:		241144
  Submitted by:	matthias.pfaller@familie-pfaller.de
  Reported by:	many
  Pointy Hat To: ler

Changes:
  head/mail/dovecot/Makefile
  head/mail/dovecot/pkg-plist
Comment 7 Larry Rosenman freebsd_committer freebsd_triage 2019-10-09 14:40:05 UTC 
I fixed it a different way (so both lus and !lua work).
Comment 8 Raúl 2019-10-09 15:11:57 UTC 
(In reply to Larry Rosenman from comment #7)
Still problems here:

[....]
===>   Registering installation for dovecot-2.3.8_1
pkg-static: Unable to access file /usr/ports/mail/dovecot/work/stage/usr/local/%%LUA_LIBDIR%%/dovecot/%%LUA_LIBDIR%%01_mail_lua_plugin.a:No such file or directory
pkg-static: Unable to access file /usr/ports/mail/dovecot/work/stage/usr/local/%%LUA_LIBDIR%%/dovecot/%%LUA_LIBDIR%%01_mail_lua_plugin.so:No such file or directory
pkg-static: Unable to access file /usr/ports/mail/dovecot/work/stage/usr/local/%%LUA_LIBDIR%%/dovecot/%%LUA_LIBDIR%%22_push_notification_lua_plugin.a:No such file or directory
pkg-static: Unable to access file /usr/ports/mail/dovecot/work/stage/usr/local/%%LUA_LIBDIR%%/dovecot/%%LUA_LIBDIR%%22_push_notification_lua_plugin.so:No such file or directory
*** Error code 74

Stop.
make: stopped in /usr/ports/mail/dovecot
[....]

@Ralf van der Enden fix, working fine
Comment 9 Larry Rosenman freebsd_committer freebsd_triage 2019-10-09 15:45:53 UTC 
I just fixed my fix.  see r514168.
Comment 10 Raúl 2019-10-09 18:13:32 UTC 
(In reply to Larry Rosenman from comment #9)

Perfect!
Thanks a lot.