Bug 241156 - science/lammps: fix build on GCC architectures
Summary: science/lammps: fix build on GCC architectures
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
Depends on:
Reported: 2019-10-09 13:31 UTC by Piotr Kubaj
Modified: 2019-11-28 14:20 UTC (History)
2 users (show)

See Also:
yuri: maintainer-feedback+

patch (352 bytes, patch)
2019-10-09 13:31 UTC, Piotr Kubaj
yuri: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-10-09 13:31:45 UTC
Created attachment 208201 [details]

Upstream PR: https://github.com/lammps/lammps/pull/1483

Don't set BUILD_OMP. libomp is correctly found and used when building with clang anyway.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-11-14 05:03:07 UTC
Now see D21994.
Comment 2 commit-hook freebsd_committer 2019-11-28 14:20:22 UTC
A commit references this bug:

Author: pkubaj
Date: Thu Nov 28 14:20:18 UTC 2019
New revision: 518579
URL: https://svnweb.freebsd.org/changeset/ports/518579

  science/lammps: fix build on GCC architectures

  Don't enable OpenMP everywhere, it causes an error with GCC, reported on https://github.com/lammps/lammps/pull/1483

  This requires some hackery with ports not supporting options for specific compilers.

  OPENMP flag has removed option helpers due to them not being respected otherwise.

  PR:		241156
  Approved by:	yuri (maintainer, earlier versior), tcberner (mentor, earlier version)
  Differential Revision:	https://reviews.freebsd.org/D21994