Bug 241207 - net-mgmt/p5-FusionInventory-Agent: Update to 2.5.1
Summary: net-mgmt/p5-FusionInventory-Agent: Update to 2.5.1
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2019-10-12 06:12 UTC by Boris Korzun
Modified: 2019-10-21 12:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (freebsd)


Attachments
Update the FusionInventory Agent to 2.5.1 (24.95 KB, patch)
2019-10-12 06:12 UTC, Boris Korzun
no flags Details | Diff
Update the FusionInventory Agent to 2.5.1 (3.39 KB, patch)
2019-10-21 12:04 UTC, Boris Korzun
no flags Details | Diff
Update the FusionInventory Agent to 2.5.1 (24.94 KB, patch)
2019-10-21 12:07 UTC, Boris Korzun
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Korzun 2019-10-12 06:12:42 UTC
Created attachment 208254 [details]
Update the FusionInventory Agent to 2.5.1

Hi,

there's a patch for updating p5-FusionInventory-Agent to 2.5.1 in the attachment.

Changes:
* Version bump (from 2.4 to 2.5.1).
* Changed MASTER_SITES from CPAN to GitHub. There's not a 2.5.1 stable version on the CPAN (only 2.5).
* Removal DAEMON option. Couldn't use RC_SUBR script with DAEMON=OFF. The option depends moved to main depends.
* Added p5-Net-Ping to BUILD depends. Needed for Deploy (2.3.18) and NetDiscovery (2.4.2).
* Added p5-Thread-Queue to BUILD depends. Needed for NetDiscovery/NetInventory (2.3.15).
* Added p5-XML-XPath to BUILD depends. Needed for HTTP daemon plugin (2.5.1).
* Changed dmidecode version depends.
* Removal nmap depends (2.4.1).
* Removal obsolete depends.
* Removal obsolete conflits.
* Added fusioninventory-remoteinventory to plist (2.5).
* Added HTTP daemon plugins to plist (2.5).
* Changed options in plist.

Best regards
Boris
Comment 1 Mathieu Simon 2019-10-21 05:57:16 UTC
Hi Boris

Thanks for the patch and your patience, I've been quite busy recently and was unable to get back to you.

There are a couple of minor things I'd like to work out before I'd like to giving my thumbs up on your patch such as (but not all):

* If we switch to github we might as well use the specific macros in the ports tree (it should spare us using long URLs)
* You've removed i.e. %DEPLOY% (unfortunately they get lost if you simply regenerate the distinfo)

To be honest, it's been a long time since I've used Fusioninventory in daemon mode on FreeBSD - good catch on finding issues in that area. If it doesn't work, we should drop it I'd say.

I'll give it a whirl in my newly-built poudriere environment and share a follow-up.

-- Mathieu
Comment 2 Boris Korzun 2019-10-21 12:04:44 UTC
Created attachment 208481 [details]
Update the FusionInventory Agent to 2.5.1

Hi Mathieu,

Okay, I've used the specific macros.
But I had not removed %DEPLOY%.

I had removed %DAEMON% as meaningless. If RC_SUBR exists (it isn't switched), it's not allowed to compile the Fusioninventory without daemon support. The %DAEMON% option SHOULD be enabled permanently.

Best regards
Boris
Comment 3 Boris Korzun 2019-10-21 12:07:39 UTC
Created attachment 208482 [details]
Update the FusionInventory Agent to 2.5.1