Bug 241228 - devel/lua-luarocks: version bump to 3.2.1 with support for lang/luajit-openresty
Summary: devel/lua-luarocks: version bump to 3.2.1 with support for lang/luajit-openresty
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-13 15:41 UTC by yds
Modified: 2019-11-05 15:35 UTC (History)
1 user (show)

See Also:


Attachments
devel/lua-luarocks: version bump to 3.2.1 with support for lang/luajit-openresty (6.92 KB, patch)
2019-10-13 15:41 UTC, yds
no flags Details | Diff
version bump to 3.2.1 with options for selecting Lua version (7.05 KB, patch)
2019-10-14 20:13 UTC, yds
no flags Details | Diff
version bump to 3.2.1 with options for selecting Lua version (7.07 KB, patch)
2019-10-14 22:10 UTC, yds
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yds 2019-10-13 15:41:05 UTC
Created attachment 208281 [details]
devel/lua-luarocks: version bump to 3.2.1 with support for lang/luajit-openresty

this patch adds DEPENDS support for lang/luajit-openresty if installed, otherwise DEPENDS on lang/luajit as before.
Comment 1 Dmitry Marakasov freebsd_committer 2019-10-14 17:20:08 UTC
> this patch adds DEPENDS support for lang/luajit-openresty if installed, otherwise DEPENDS on lang/luajit as before.

Please provide an explicit option to depend on luajit-openresty instead.
Comment 2 yds 2019-10-14 20:13:05 UTC
Created attachment 208314 [details]
version bump to 3.2.1 with options for selecting Lua version

version bump to 3.2.1 with options for selecting Lua version.

> Please provide an explicit option to depend on luajit-openresty instead.

Trying to fulfill the request above I realized there no difference in installing LuaRocks for Lua 5.1 and any of the LuaJIT variants.  Therefore there is no need to explicitly depend on any of the LuaJIT ports.

Instead this new patch adds options for building and installing LuaRocks to support any version of Lua.  This probably closes [Bug 229520](https://Bugs.FreeBSD.org/bugzilla/show_bug.cgi?id=229520)
Comment 3 yds 2019-10-14 22:10:39 UTC
Created attachment 208316 [details]
version bump to 3.2.1 with options for selecting Lua version

make OPTIONS_DEFAULT honor the system wide LUA_DEFAULT yet still allow building and installing the port for the other non-default versions of Lua
Comment 4 Dmitry Marakasov freebsd_committer 2019-10-28 15:54:51 UTC
I think you need FLAVORS here. Among the other benefits it'll allow to have package for each version of luarocks and install them simultaneously (though it'll need minor installation for to add -${LUA_VER} suffix to binaries as it's done with config.

See https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html for details.
Comment 5 Dmitry Marakasov freebsd_committer 2019-11-05 15:35:59 UTC
Any progress?