Bug 241382 - net/samba48, net/samba410 make LibZFS optional for real
Summary: net/samba48, net/samba410 make LibZFS optional for real
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-20 21:53 UTC by lytboris
Modified: 2019-10-25 07:30 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (timur)


Attachments
Initial version (1.43 KB, text/plain)
2019-10-20 21:53 UTC, lytboris
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description lytboris 2019-10-20 21:53:12 UTC
Created attachment 208471 [details]
Initial version

Even though LibZFS has knob in OPTIONS, it is expected to build every time as per pkg-plist.

Patch proposed makes it optional for real.
Comment 1 lytboris 2019-10-20 22:00:51 UTC
Patch is incomplete, will post a new PR once tested properly.
Comment 2 Timur I. Bakeyev freebsd_committer 2019-10-21 00:01:57 UTC
I think you are confused what ZFS ACL VFS module is doing
Comment 3 lytboris 2019-10-24 20:29:40 UTC
Yeah, most probably.

Is there any reason to keep LIBZFS option semi-implemented in Makefile?
Comment 4 Timur I. Bakeyev freebsd_committer 2019-10-25 07:30:53 UTC
(In reply to lytboris from comment #3)

This is remain of the times I was trying to merge iXsystems Samba port and the FreeBSD one.

This still has to be implemented, as it provides additional value, but first libZFS has to be reliably build from the existing source code/ports tree.

So far I couldn't find reliable solution for this...