Created attachment 208509 [details]
Repocopy lang/python37 --> lang/python38 and update to 3.8.0
Need to integrate this with https://reviews.freebsd.org/D19822
> Need to integrate this with https://reviews.freebsd.org/D19822
Umm, why? This patch supersedes that review completely, it could just be dropped.
"if / where necessary"
I didn't review each patchset
Any reason why --enable-optimizations isn't used?
I've tested it with some ports and it works great. Anything delaying the commit?
Review, confirmation of QA & python@ approval on attachment 208509 [details] as is normal
A commit references this bug:
Date: Sat Nov 2 23:40:42 UTC 2019
New revision: 516377
- Repocopy lang/python37 --> python38 and update to 3.8.0
Submitted by: wen@(myself)
Reviewed by: koobs@, amdmi3@
(In reply to commit-hook from comment #7)
Note: I didn't review this, and still have questions for understanding the removal of files/patch-Makefile.pre.in
(In reply to Kubilay Kocak from comment #8)
Sorry for add you to reviewer.
But files/patch-Makefile.pre.in had not been removed.
There are problems:
- _sqlite3 _tkinter _gdbm are no longer disabled
- with DEBUG turned on it fails to package
(In reply to Antoine Brodin from comment #10)
Thank you !
I shall fix it later.
(In reply to Wen Heping from comment #9)
Apologies, I meant files/patch-Makefile.pre.in *modification*, with removal of the block that creates symlinks for non-ABI-suffixed files:
# Description: Create symlinks for non-ABI-suffixed python*-config and ABI-suffixed python-*.pc
# Submitted by: antoine@ (r358029)
# TODO: Upstream
(In reply to Kubilay Kocak from comment #12)
Thank you again!
The removal of the patch(files/patch-Makefile.pre.in modification) which creatd by antoine@ will result in package error, I shall re-test it later.