Bug 241416 - [NEW PORT] lang/python38
Summary: [NEW PORT] lang/python38
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2019-10-22 15:10 UTC by Wen Heping
Modified: 2020-08-02 14:02 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (python)

Attachments
repocopy python37-->python38 (57.16 KB, patch)
2019-10-22 15:10 UTC, Wen Heping 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wen Heping freebsd_committer 2019-10-22 15:10:00 UTC 
Created attachment 208509 [details]
repocopy python37-->python38

Repocopy lang/python37 --> lang/python38 and update to 3.8.0
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-10-23 02:16:18 UTC 
Need to integrate this with https://reviews.freebsd.org/D19822
Comment 2 Dmitry Marakasov freebsd_committer 2019-10-24 18:26:46 UTC 
> Need to integrate this with https://reviews.freebsd.org/D19822

Umm, why? This patch supersedes that review completely, it could just be dropped.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-10-25 05:08:28 UTC 
"if / where necessary"

I didn't review each patchset
Comment 4 daniel.engberg.lists 2019-10-28 07:46:07 UTC 
Any reason why --enable-optimizations isn't used?
Comment 5 Dmitry Marakasov freebsd_committer 2019-10-31 19:01:45 UTC 
I've tested it with some ports and it works great. Anything delaying the commit?
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2019-11-01 02:06:28 UTC 
Review, confirmation of QA & python@ approval on attachment 208509 [details] as is normal
Comment 7 commit-hook freebsd_committer 2019-11-02 23:41:12 UTC 
A commit references this bug:

Author: wen
Date: Sat Nov  2 23:40:42 UTC 2019
New revision: 516377
URL: https://svnweb.freebsd.org/changeset/ports/516377

Log:
  - Repocopy lang/python37 --> python38 and update to 3.8.0

  PR:		241416
  Submitted by:	wen@(myself)
  Reviewed by:	koobs@, amdmi3@

Changes:
  head/Mk/Uses/python.mk
  head/Mk/bsd.default-versions.mk
  head/lang/Makefile
  head/lang/python-doc-html/distinfo
  head/lang/python38/
  head/lang/python38/Makefile
  head/lang/python38/Makefile.version
  head/lang/python38/distinfo
  head/lang/python38/files/patch-Makefile.pre.in
  head/lang/python38/files/patch-issue20210
  head/lang/python38/pkg-plist
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2019-11-03 01:59:09 UTC 
(In reply to commit-hook from comment #7)

Note: I didn't review this, and still have questions for understanding the removal of files/patch-Makefile.pre.in
Comment 9 Wen Heping freebsd_committer 2019-11-03 02:35:18 UTC 
(In reply to Kubilay Kocak from comment #8)
Sorry for add you to reviewer.
But files/patch-Makefile.pre.in had not been removed.

wen
Comment 10 Antoine Brodin freebsd_committer 2019-11-03 07:26:34 UTC 
There are problems:

- _sqlite3 _tkinter _gdbm are no longer disabled

- with DEBUG turned on it fails to package
Comment 11 Wen Heping freebsd_committer 2019-11-03 08:22:16 UTC 
(In reply to Antoine Brodin from comment #10)
Thank you !
I shall fix it later.

wen
Comment 12 Kubilay Kocak freebsd_committer freebsd_triage 2019-11-03 09:03:57 UTC 
(In reply to Wen Heping from comment #9)

Apologies, I meant files/patch-Makefile.pre.in *modification*, with removal of the block that creates symlinks for non-ABI-suffixed files:

# Description: Create symlinks for non-ABI-suffixed python*-config and ABI-suffixed python-*.pc 	 
# Submitted by: antoine@ (r358029) 	 
# TODO: Upstream

Diff: https://svnweb.freebsd.org/ports/head/lang/python38/files/patch-Makefile.pre.in?r1=516377&r2=516375&pathrev=516377
Comment 13 Wen Heping freebsd_committer 2019-11-03 09:15:46 UTC 
(In reply to Kubilay Kocak from comment #12)
Thank you again!

The removal of the patch(files/patch-Makefile.pre.in modification) which creatd by antoine@ will result in package error, I shall re-test it later.

wen
Comment 14 John Hein 2020-02-07 11:20:58 UTC 
(In reply to Antoine Brodin from comment #10)
See bug 243937 for a fix for disabling extensions.