Created attachment 208669 [details] py-iso-639-0.4.5.shar https://pypi.org/project/iso-639/
Upstream specifies 'Programming Language :: Python :: 3.5', as the latest Python version it supports. If not explicitly tested (with its test suite) for > 3.5, the port should be limited to specify only the versions it *does* support. It might be worth using the github sources as the PyPI sdist doesn't include a LICENSE_FILE or the tests Also, unless this package doesn't require Python at runtime, "USES= python:build" incorrectly states that Python is *only* needed at build time. Please also confirm that the port passes QA (portlint, poudriere, make test)
Created attachment 208685 [details] py-iso639-0.4.5.shar I've tested it, but it doesn't seem to implement test code. ># python3.6 -m unittest -v iso639 > >---------------------------------------------------------------------- >Ran 0 tests in 0.000s > >OK Changed the source code distribution to GitHub. The PORTNAME has been changed due to this change. You have explicitly specified a license file. Fixed to USES=python in the Makefile.
(In reply to takefu from comment #2) PORTNAME for Python packages *must* be named after their PyPI name where they are registered there. This is usually the same as whats declared in setup.py:name, but can be different (dashes vs underscores), so PyPI name is canonical. iso639 is a different and separate package [1] This packages name is 'iso-639' [2] so please use that. [1] https://pypi.org/project/iso639/ [2] https://pypi.org/project/iso-639/
Also, I see in the setup.py Trove classifiers, the following: 'Topic :: Text Processing :: Linguistic', textproc is probably the better primary category for this, and/as we like to avoid misc where possible
Created attachment 208688 [details] py-iso-639-0.4.5.shar comment #3 I understand. put it back. comment #4 Category changed. misc -> textproc
Created attachment 209642 [details] py-iso-639-0.4.5.shar category change. misc -> textproc
A commit references this bug: Author: mandree Date: Sat Apr 25 23:21:11 UTC 2020 New revision: 532986 URL: https://svnweb.freebsd.org/changeset/ports/532986 Log: New port: textproc/py-iso-639: Python library for ISO 639 standard PR: 241564 Submitted by: takefu@airport.fm (maintainer) Changes: head/textproc/Makefile head/textproc/py-iso-639/ head/textproc/py-iso-639/Makefile head/textproc/py-iso-639/distinfo head/textproc/py-iso-639/files/ head/textproc/py-iso-639/files/patch-setup.py head/textproc/py-iso-639/pkg-descr
A commit references this bug: Author: mandree Date: Sat Apr 25 23:30:14 UTC 2020 New revision: 532987 URL: https://svnweb.freebsd.org/changeset/ports/532987 Log: textproc/py-iso-639: add NO_ARCH=yes While here, sort USE_PYTHON. Bump PORTREVISION. Forgotten in PR: 241564 Brown paper bag to: mandree@ Changes: head/textproc/py-iso-639/Makefile