Bug 241564 - [NEW PORT] textproc/py-iso-639: Python library for ISO 639 standard
Summary: [NEW PORT] textproc/py-iso-639: Python library for ISO 639 standard
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL: https://pypi.org/project/iso-639/
Keywords: feature
Depends on:
Blocks: 241566
  Show dependency treegraph
Reported: 2019-10-29 05:41 UTC by takefu
Modified: 2020-04-27 10:08 UTC (History)
3 users (show)

See Also:
mandree: maintainer-feedback+

py-iso-639-0.4.5.shar (931 bytes, application/x-shellscript)
2019-10-29 05:41 UTC, takefu
no flags Details
py-iso639-0.4.5.shar (1.98 KB, application/x-shellscript)
2019-10-30 02:14 UTC, takefu
no flags Details
py-iso-639-0.4.5.shar (2.01 KB, patch)
2019-10-30 05:07 UTC, takefu
no flags Details | Diff
py-iso-639-0.4.5.shar (2.01 KB, application/x-shellscript)
2019-12-03 05:48 UTC, takefu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2019-10-29 05:41:12 UTC
Created attachment 208669 [details]

Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-10-29 05:47:38 UTC
Upstream specifies 'Programming Language :: Python :: 3.5', as the latest Python version it supports. If not explicitly tested (with its test suite) for > 3.5, the port should be limited to specify only the versions it *does* support.

It might be worth using the github sources as the PyPI sdist doesn't include a LICENSE_FILE or the tests

Also, unless this package doesn't require Python at runtime, "USES=		python:build" incorrectly states that Python is *only* needed at build time.

Please also confirm that the port passes QA (portlint, poudriere, make test)
Comment 2 takefu 2019-10-30 02:14:44 UTC
Created attachment 208685 [details]

I've tested it, but it doesn't seem to implement test code.

># python3.6 -m unittest -v iso639
>Ran 0 tests in 0.000s

Changed the source code distribution to GitHub.
The PORTNAME has been changed due to this change.
You have explicitly specified a license file.
Fixed to USES=python in the Makefile.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-10-30 02:18:40 UTC
(In reply to takefu from comment #2)

PORTNAME for Python packages *must* be named after their PyPI name where they are registered there. This is usually the same as whats declared in setup.py:name, but can be different (dashes vs underscores), so PyPI name is canonical.

iso639 is a different and separate package [1]

This packages name is 'iso-639' [2] so please use that.

[1] https://pypi.org/project/iso639/
[2] https://pypi.org/project/iso-639/
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2019-10-30 02:19:55 UTC
Also, I see in the setup.py Trove classifiers, the following:

'Topic :: Text Processing :: Linguistic',

textproc is probably the better primary category for this, and/as we like to avoid misc where possible
Comment 5 takefu 2019-10-30 05:07:29 UTC
Created attachment 208688 [details]

comment #3
I understand.
put it back.

comment #4
Category changed.
  misc -> textproc
Comment 6 takefu 2019-12-03 05:48:53 UTC
Created attachment 209642 [details]

category change.
  misc -> textproc
Comment 7 commit-hook freebsd_committer 2020-04-25 23:21:14 UTC
A commit references this bug:

Author: mandree
Date: Sat Apr 25 23:21:11 UTC 2020
New revision: 532986
URL: https://svnweb.freebsd.org/changeset/ports/532986

  New port: textproc/py-iso-639: Python library for ISO 639 standard

  PR:		241564
  Submitted by:	takefu@airport.fm (maintainer)

Comment 8 commit-hook freebsd_committer 2020-04-25 23:30:16 UTC
A commit references this bug:

Author: mandree
Date: Sat Apr 25 23:30:14 UTC 2020
New revision: 532987
URL: https://svnweb.freebsd.org/changeset/ports/532987

  textproc/py-iso-639: add NO_ARCH=yes

  While here, sort USE_PYTHON.


  Forgotten in
  PR:			241564
  Brown paper bag to:	mandree@