Bug 241566 - [NEW PORT] net/streamlink: Command-line utility that pipes video streams
Summary: [NEW PORT] net/streamlink: Command-line utility that pipes video streams
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL: https://streamlink.github.io/
Keywords: feature, needs-patch, needs-qa
Depends on: 241564 241565 239302
Blocks:
  Show dependency treegraph
 
Reported: 2019-10-29 05:46 UTC by takefu
Modified: 2020-02-23 20:33 UTC (History)
6 users (show)

See Also:
takefu: maintainer-feedback+


Attachments
py-streamlink-1.2.0.shar (2.35 KB, application/x-shellscript)
2019-10-29 05:46 UTC, takefu
no flags Details
py-streamlink-1.2.0.shar (1.79 KB, application/x-shellscript)
2019-10-30 02:50 UTC, takefu
no flags Details
py-streamlink-1.2.0.shar (1.79 KB, application/x-shellscript)
2019-10-30 05:14 UTC, takefu
no flags Details
py-streamlink-1.3.0.shar (1.85 KB, application/x-shellscript)
2019-12-03 06:04 UTC, takefu
no flags Details
py-streamlink-1.3.0.shar (1.88 KB, application/x-shellscript)
2019-12-05 07:52 UTC, takefu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2019-10-29 05:46:55 UTC
Created attachment 208671 [details]
py-streamlink-1.2.0.shar

request update
  www/py-requests
  Bug #239302

request new port
  misc/py-iso-639  bug #241564
  misc/py-iso3166  bug #241565

https://streamlink.github.io/
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-10-29 09:12:34 UTC
Review items:

1) pip, and test related dependencies (pytest, pytest-cov, codecov, coverage, mock, requests-mock, freezegun *at least*) should not be required as RUN_DEPENDS.

Port dependencies should exactly match (including any version specifiers):

setup.py:install_requires (RUN_DEPENDS)
setup.py:setup_requires (BUILD_DEPENDS)
setup.py:tests_require (TEST_DEPENDS)

2) python:build,run is the same as USES=python

3) MASTER_SITES should default to CHEESESHOP unless there is a compelling (temporary) reason to use an alternative source like GitHub, such as if LICENSE_FILE or tests are missing from PyPI source distribution.
Comment 2 takefu 2019-10-30 02:50:43 UTC
Created attachment 208686 [details]
py-streamlink-1.2.0.shar

comment #1

1&2&3) Fixed.

changed to py-iso-639 -> py-iso639
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-10-30 03:04:28 UTC
Need to revert py-iso369 change (see bug 241564 comment 3)
Comment 4 takefu 2019-10-30 05:14:49 UTC
Created attachment 208690 [details]
py-streamlink-1.2.0.shar

bug #241564 comment #4
bug #241565 comment #1
Follow category changes.
Comment 5 takefu 2019-12-03 06:04:36 UTC
Created attachment 209643 [details]
py-streamlink-1.3.0.shar

Version 1.3.0
Comment 7 Naram Qashat 2019-12-04 16:09:24 UTC
I was going to submit this myself after the update of py-urllib3, but looks like you beat me to it. However, I have a few issues with the Makefile for the port:

* I feel the category should be multimedia, like livestreamer was, not net.
* The dependency on security/py-cryptodome is missing.
* It might not be necessary to list py-urllib as a direct dependency of streamlink because it is included by py-requests.
* This doesn't handle the case of someone wanting to build a version of Streamlink for Python 2.7, that requires devel/py-futures, devel/py-singledispatch, devel/py-backports.shutil_get_terminal_size, as well as py-backports.shutil_which (not currently in the ports tree).

Otherwise I look forward to getting this officially in the ports tree finally.
Comment 8 takefu 2019-12-05 07:52:52 UTC
Created attachment 209713 [details]
py-streamlink-1.3.0.shar

(In reply to Naram Qashat from comment #7)

category change
  net -> multimedia

net/py-urllib3 Deleted as pointed out.

Declared USES=python:3.5+ because Python2.7 is not considered.
Comment 9 VVD 2020-02-23 20:33:52 UTC
Who can commit this?