Bug 241573 - usr.sbin/services_mkdb/services: Add SSDP to service database (Used for UPnP in 12.1 at least)
Summary: usr.sbin/services_mkdb/services: Add SSDP to service database (Used for UPnP ...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Pedro F. Giffuni
URL: https://www.iana.org/assignments/serv...
Keywords: easy, feature
Depends on:
Blocks:
 
Reported: 2019-10-29 16:31 UTC by PauAmma
Modified: 2020-06-19 03:09 UTC (History)
2 users (show)

See Also:
pfg: mfc-stable12+
koobs: mfc-stable11-


Attachments
Add SSDP to services (731 bytes, patch)
2019-11-04 03:54 UTC, PauAmma
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description PauAmma freebsd_triage 2019-10-29 16:31:53 UTC
[pauamma@gadfly] ~% grep 1900 /etc/services
[pauamma@gadfly] ~% grep -i ssdp /etc/services
[pauamma@gadfly] ~% 

Excerpt from the IANA port numbers list:
ssdp	1900	tcp	SSDP	[UPnP_Forum]	[UPnP_Forum]						
ssdp	1900	udp	SSDP	[UPnP_Forum]	[UPnP_Forum]
Comment 1 PauAmma freebsd_triage 2019-11-04 03:54:18 UTC
Created attachment 208838 [details]
Add SSDP to services

Tested with: services_mkdb -o /tmp/services.13-CURRENT.db ~/src_current/usr.sbin/services_mkdb/services && echo "All good!"
Comment 2 Kyle Evans freebsd_committer 2020-06-07 04:14:13 UTC
CC'ing pfg@, who was trying to update services but had ran into some obstacles.
Comment 3 Pedro F. Giffuni freebsd_committer 2020-06-07 05:49:24 UTC
Yes, thanks!

Indeed I skipped this from the recent update and it is not in my WIP differential:

https://reviews.freebsd.org/D23621

I think we can go ahead and commit the change and it will not conflict with my update. There is a PROTOMAX limit on older releases but I doubt we will hit for just one value.
I will do it unless someone does it first ;).
Comment 4 commit-hook freebsd_committer 2020-06-07 19:57:02 UTC
A commit references this bug:

Author: pfg
Date: Sun Jun  7 19:56:17 UTC 2020
New revision: 361898
URL: https://svnweb.freebsd.org/changeset/base/361898

Log:
  services: Add SSDP to service database

  This is used for UPnP and is registered in the IANA database.

  MFC after:	2 weeks
  PR:		241573

Changes:
  head/usr.sbin/services_mkdb/services
Comment 5 commit-hook freebsd_committer 2020-06-18 22:10:12 UTC
A commit references this bug:

Author: pfg
Date: Thu Jun 18 22:10:06 UTC 2020
New revision: 362345
URL: https://svnweb.freebsd.org/changeset/base/362345

Log:
  services: Add SSDP to service database

  This is used for UPnP and is registered in the IANA database.

  PR:		241573

Changes:
_U  stable/12/
  stable/12/usr.sbin/services_mkdb/services
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-06-19 03:09:52 UTC
^Triage: Track (non) merge to stable/11