Bug 241588 - security/opensc: fix build on powerpc and arm
Summary: security/opensc: fix build on powerpc and arm
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-30 12:21 UTC by Piotr Kubaj
Modified: 2019-10-30 14:59 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ale)


Attachments
patch (1.62 KB, patch)
2019-10-30 12:21 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (ale)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-10-30 12:21:39 UTC
Created attachment 208698 [details]
patch

Upgrade to new GCC on GCC architectures instead of removing compilator flags. This will simplify the Makefile.

Explicitly set signed char. command variable is later compared to -1, which fails on architectures that use unsigned char by default, like arm and powerpc.
Comment 1 commit-hook freebsd_committer 2019-10-30 14:59:32 UTC
A commit references this bug:

Author: ale
Date: Wed Oct 30 14:58:42 UTC 2019
New revision: 516062
URL: https://svnweb.freebsd.org/changeset/ports/516062

Log:
  Fix build on powerpc and arm

  PR:		241588
  Submitted by:	pkubaj

Changes:
  head/security/opensc/Makefile
  head/security/opensc/files/patch-src_tests_p11test_p11test.c