Bug 241594 - devel/grpc: Update to 1.24.3
Summary: devel/grpc: Update to 1.24.3
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Tobias C. Berner
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2019-10-30 19:41 UTC by Neel Chauhan
Modified: 2019-11-20 14:24 UTC (History)
4 users (show)

See Also:
neel: maintainer-feedback+


Attachments
Patch (Revision 1) (4.87 KB, patch)
2019-10-30 19:41 UTC, Neel Chauhan
neel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan 2019-10-30 19:41:00 UTC
Created attachment 208707 [details]
Patch (Revision 1)

Builds on FreeBSD 12.0 amd64.
Comment 1 Automation User 2019-10-30 21:54:49 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/92680784
Comment 2 commit-hook freebsd_committer 2019-11-02 11:47:44 UTC
A commit references this bug:

Author: tcberner
Date: Sat Nov  2 11:47:01 UTC 2019
New revision: 516302
URL: https://svnweb.freebsd.org/changeset/ports/516302

Log:
  devel/grpc: Update to 1.24.3

  PR:		241594
  Submitted by:	Neel Chauhan <neel@neelc.org> (maintainer)

Changes:
  head/devel/grpc/Makefile
  head/devel/grpc/distinfo
  head/devel/grpc/pkg-plist
Comment 3 Tobias C. Berner freebsd_committer 2019-11-02 12:03:33 UTC
Committed. Thanks.
Comment 4 commit-hook freebsd_committer 2019-11-05 16:26:05 UTC
A commit references this bug:

Author: swills
Date: Tue Nov  5 16:25:34 UTC 2019
New revision: 516808
URL: https://svnweb.freebsd.org/changeset/ports/516808

Log:
  devel/grpc: revert r516302

  This update seems to break at least science/py-tensorflow and
  net/rubygem-grpc

  PR:		241594
  Discussed with:	tcberner
  With hat:	portmgr

Changes:
  head/devel/grpc/Makefile
  head/devel/grpc/distinfo
  head/devel/grpc/pkg-plist
Comment 5 Steve Wills freebsd_committer 2019-11-05 16:27:57 UTC
Reopen due to revert
Comment 6 James Wright 2019-11-07 21:09:53 UTC
(In reply to commit-hook from comment #4)

It also broke sysutils/apache-mesos, which I patched for the new version, and now breaks due to the reversion back to 1.22.

The fix to mesos for using grpc 1.24 was pretty simple, just a namespace change;
https://reviews.freebsd.org/D22238

Can we not do the same for py-tensorflow?
Comment 7 commit-hook freebsd_committer 2019-11-20 14:24:24 UTC
A commit references this bug:

Author: lwhsu
Date: Wed Nov 20 14:23:26 UTC 2019
New revision: 518021
URL: https://svnweb.freebsd.org/changeset/ports/518021

Log:
  Unbreak by reverting the patch for grpc 1.24, which was downgraded to 1.22 [1]

  PR:		241933, 241594 [1]
  Submitted by:	James Wright <james.wright@digital-chaos.com>

Changes:
  head/sysutils/apache-mesos/Makefile
  head/sysutils/apache-mesos/files/patch-3rdparty_libprocess_include_process_grpc.hpp