Bug 241691 - [NEW PORT] devel/py-pecan: WSGI object-dispatching web framework
Summary: [NEW PORT] devel/py-pecan: WSGI object-dispatching web framework
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2019-11-03 17:09 UTC by Willem Jan Withagen
Modified: 2019-11-05 13:35 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (wjw)


Attachments
svn diff for net port (2.20 KB, patch)
2019-11-03 17:09 UTC, Willem Jan Withagen
no flags Details | Diff
New svn-diff for pecan (2.77 KB, patch)
2019-11-05 12:01 UTC, Willem Jan Withagen
no flags Details | Diff
3rd version for py-pecan (3.31 KB, patch)
2019-11-05 13:35 UTC, Willem Jan Withagen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Willem Jan Withagen 2019-11-03 17:09:57 UTC
Created attachment 208824 [details]
svn diff for net port

Follows the template of just about every CHEESESHOP py module
Comment 1 Willem Jan Withagen 2019-11-03 17:20:14 UTC
package will be used by the net/ceph* ports
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-11-04 06:57:03 UTC
Thank you for the new port and patch Willem.

Review items:

- Missing RUN_DEPENDS. See setup.py:install_requires=requirements, which pulls from requirements.txt

- Missing dependency on singledispatch for PYTHON_VER < 3.4

- Package installs a script in LOCALBASE/bin. Ports doing so (or in other non-python version-specific locations), must be concurrent safe. Add USE_PYTHON=concurrent

- If you can, add TEST_DEPENDS and a test target for QA purposes. Package includes tests_require (for test dependencies) and test_suite in setup.py so it should be as simple as a '${PYTHON_CMD} ${PYDISTUTILS_SETUP} test' call in a do-test: target

Please also confirm the port passes QA (portlint and poudriere for python27/36 at least, in particular)
Comment 3 Willem Jan Withagen 2019-11-05 12:01:13 UTC
Created attachment 208876 [details]
New svn-diff for pecan
Comment 4 Willem Jan Withagen 2019-11-05 12:02:14 UTC
New patch uploaded.

portlint and poudriere are both happy
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2019-11-05 12:07:47 UTC
(In reply to Willem Jan Withagen from comment #4)

Looks great Willem, nice work!
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2019-11-05 12:22:31 UTC
Sorry, I didn't notice before:

- Set install_requires as RUN_DEPENDS (not test depends)
- Test dependencies dont need to include run depends (theyre implicit). upstream shouldn't be including them in tests_require. these are the real test dependencies:

test-requirements.txt:

gunicorn
Jinja2
mock
pep8
sqlalchemy
uwsgi

virtualenv should not be necessary to test

- Still missing dependency on singledispatch for PYTHON_VER < 3.4

.include <bsd.port.pre.mk>
.if ${PYTHON_VER} < 3.4
RUN_DEPENDS+= singledispatch 
.endif

.include <bsd.port.pre.mk> (last line)

- For multiple *_DEPENDS lines, use \ to separate dependencies per line rather than TEST_DEPENDS= and multiple  TEST_DEPENDS+=
Comment 7 Willem Jan Withagen 2019-11-05 13:35:55 UTC
Created attachment 208879 [details]
3rd version for py-pecan

More fixes as requested