Created attachment 208830 [details]
All ports have been switched to use USES=xorg-cat, so the old XORG_CAT fallback from bsd.port.mk can be removed. See attachement from patch.
I've run this locally several times (for all ports that set USES=xorg-cat or XORG_CAT), there is no need for an exp-run, I think.
I hope to get approval to commit.
Any removed variable needs to be added to bsd.sanity.mk.
Created attachment 208853 [details]
Updated patch with additions to bsd.sanity.mk.
For some reason I can't mark v1 as obsolete, sorry.
Looks fine by me, not sure an exp-run is required either.
A commit references this bug:
Date: Mon Nov 4 18:08:21 UTC 2019
New revision: 516730
Retire XORG_CAT, it is not needed since all ports has moved to use
Add a check to bsd.sanity.mk causing an error if any port happens to set it
in the future.
Approved by: portmgr (mat)
Leave this open for a day or two in case there's fallout.
A full package build run has been done since this was committed, with no fallout, so closing this.