Bug 241764 - audio/audacity: Use FFmpeg for decoding instead of libmad
Summary: audio/audacity: Use FFmpeg for decoding instead of libmad
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-06 18:53 UTC by daniel.engberg.lists
Modified: 2019-11-08 21:49 UTC (History)
2 users (show)

See Also:
xxjack12xx: maintainer-feedback-


Attachments
Replace libmad with ffmpeg (1.34 KB, patch)
2019-11-06 18:53 UTC, daniel.engberg.lists
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2019-11-06 18:53:18 UTC
Created attachment 208920 [details]
Replace libmad with ffmpeg

Main reason is because FFmpeg is quite a bit faster than libmad which hasn't seen any upstream development for several years. While FFmpeg has more dependencies it's very likey to have it already installed in a desktop environment.
Comment 1 Jack 2019-11-07 03:17:06 UTC
Looking at upstream, it looks like the default is libmad instead of ffmpeg so best to keep compatibility with upstream and keep ffmpeg as optional (but available if user chooses to use it instead).
Comment 2 Tatsuki Makino 2019-11-08 05:22:45 UTC
echo "audio_audacity_SET=FFMPEG" >> /etc/make.conf
echo "audio_audacity_UNSET=MAD" >> /etc/make.conf
Comment 3 daniel.engberg.lists 2019-11-08 21:33:21 UTC
Thanks for the pointers but I'm more concerned about performance and not to mention code quality as libmad can quite safely be considered dead upstream. Additionally there seems to be a few CVEs that aren't patched in the current tree that should probably be patched overall. https://www.cvedetails.com/vulnerability-list/vendor_id-16426/product_id-37499/year-2017/Underbit-Mad-Libmad.html

I'm not going to push this any further but I think the aspects mentioned above should be kept in mind.
Comment 4 Jack 2019-11-08 21:49:32 UTC
Best to bring that up with the audacity developers so we can incorporate the changes.