Created attachment 208920 [details]
Replace libmad with ffmpeg
Main reason is because FFmpeg is quite a bit faster than libmad which hasn't seen any upstream development for several years. While FFmpeg has more dependencies it's very likey to have it already installed in a desktop environment.
Looking at upstream, it looks like the default is libmad instead of ffmpeg so best to keep compatibility with upstream and keep ffmpeg as optional (but available if user chooses to use it instead).
echo "audio_audacity_SET=FFMPEG" >> /etc/make.conf
echo "audio_audacity_UNSET=MAD" >> /etc/make.conf
Thanks for the pointers but I'm more concerned about performance and not to mention code quality as libmad can quite safely be considered dead upstream. Additionally there seems to be a few CVEs that aren't patched in the current tree that should probably be patched overall. https://www.cvedetails.com/vulnerability-list/vendor_id-16426/product_id-37499/year-2017/Underbit-Mad-Libmad.html
I'm not going to push this any further but I think the aspects mentioned above should be kept in mind.
Best to bring that up with the audacity developers so we can incorporate the changes.