Bug 241767 - textproc/py-chardet: Incorrectly BUILD_DEPENDS on pytest
Summary: textproc/py-chardet: Incorrectly BUILD_DEPENDS on pytest
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ruslan Makhmatkhanov
Keywords: easy, needs-patch, needs-qa
Depends on:
Reported: 2019-11-06 21:30 UTC by Enji Cooper
Modified: 2019-11-13 10:59 UTC (History)
1 user (show)

See Also:
rm: maintainer-feedback+
koobs: merge-quarterly?


Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer 2019-11-06 21:30:41 UTC
textproc/py-chardet requires a pytest package to build, when in reality it’s not required, except for test [1]. The dependency should be moved to TEST_DEPENDS.

1. https://svnweb.freebsd.org/ports/head/textproc/py-chardet/Makefile?revision=498530&view=markup#l17
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-11-08 03:54:50 UTC
Confirmed, the dependency is only added when setup.py argument is test, pytest or ptr.

@Enji This change proposal (patch and QA pending) is:

Approved by: portmgr (blanket(s): ports (python) compliance, dependency fix)
MFH: 2019Q4 (blanket: ports/dependency fix)
Comment 2 Ruslan Makhmatkhanov freebsd_committer 2019-11-13 10:59:19 UTC
Feel free to commit this change. Thank you and sorry for late response.