Bug 241788 - devel/electron4 poudriere build fails at configure stage
Summary: devel/electron4 poudriere build fails at configure stage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
Depends on:
Reported: 2019-11-07 20:21 UTC by Robert Cina
Modified: 2019-11-14 09:10 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (tagattie)


Note You need to log in before you can comment on or make changes to this bug.
Description Robert Cina 2019-11-07 20:21:47 UTC
The port devel/electron4 fails to build in poudriere for me because of an error during the configure stage.

Below is the output of the failure at the configure stage:

use_gnome_keyring=false  use_jumbo_build=true  use_lld=true  use_sysroot=false  use_system_freetype=true  use_system_harfbuzz=true  use_system_libjpeg=true  extra_cxxflags="-O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include "  extra_ldflags=" -fstack-protector-strong -L/usr/local/lib " use_alsa=true use_cups=true use_kerberos=true use_pulseaudio=false'
ERROR at //third_party/protobuf/proto_library.gni:348:15: Only source, header, and object files belong in the sources of a static_library. //out/Release/pyproto/google_apis/gcm/protocol/mcs_pb2.py is not one of the valid types.
    sources = get_target_outputs(":$action_name")
See //google_apis/gcm/BUILD.gn:77:1: whence it was called.
proto_library("proto") {
See //BUILD.gn:80:7: which caused the file to be included.
*** Error code 1

make: stopped in /usr/ports/devel/electron4
=>> Cleaning up wrkdir
===>  Cleaning for electron4-4.2.9
build of devel/electron4 | electron4-4.2.9 ended at Thu Nov  7 14:49:05 EST 2019
build time: 00:11:20
!!! build failure encountered !!!
Comment 1 tech-lists 2019-11-08 15:47:15 UTC
I'm also seeing this in poudriere on 12-stable, ports tree as of 15:46 08/11
Comment 2 Hiroki Tagato 2019-11-09 10:40:14 UTC
Thanks for reporing the error.

Recently, devel/chromium-gn, on which devel/electron4 depends, has been updated to 78.0.3904.87. It appears the updated gn command is too new for electron4.

The change made at the commit:
is the cause of the error.

I will make some changes to stop depending on devel/chromium-gn and to use an older (known to work) version of gn.
Comment 3 Luca Pizzamiglio freebsd_committer 2019-11-14 09:10:50 UTC
A newer version has been committed with support for the latest gn.