Bug 241822 - [PATCH]Update port: japanese/font-ipamjm
Summary: [PATCH]Update port: japanese/font-ipamjm
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2019-11-09 13:48 UTC by Tomoaki AOKI
Modified: 2022-05-05 06:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (hrs)


Attachments
Update to 006.01 (2.12 KB, patch)
2019-11-09 13:48 UTC, Tomoaki AOKI
no flags Details | Diff
patch for japanese/font-ipamjm (1.59 KB, patch)
2019-12-03 01:15 UTC, Tatsuki Makino
tatsuki_makino: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoaki AOKI 2019-11-09 13:48:29 UTC
Created attachment 208997 [details]
Update to 006.01

japanese/font-ipamjm was marked as BROKEN due to unfetchable.
This is already updated to 006.01 upstream and is fetchable.
Sync to upstream not to be deleted.
Comment 1 Automation User 2019-11-24 04:48:19 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/98100604
Comment 2 Tatsuki Makino 2019-12-03 01:15:43 UTC
Created attachment 209636 [details]
patch for japanese/font-ipamjm

佐藤氏が適切に処理してくださると思うのですが、他のコミッターさんでもコミットできるパッチを用意するにあたってこちらの方が良いのではないかと思う点がいくつかあったので、代案として私からもパッチを上げさせていただきます。
・内部にディレクトリを持たず、ファイルをぶちまけてくださるdistfileには、NO_WRKSUBDIRを使うらしい。
・SUB_FILESに特定の名前のファイルを指定すると、自動的にWRKDIRに生成されたものを使うように変数を書き換える(Mk/bsd.port.mkのapply-slistターゲットのあたり)らしいので、そのあたりを省略。
・Readme.txtはありきたりな名前だが、 /usr/local/share/doc/ipamjm というパッケージ別のディレクトリへインストールするので、特に名前の重複を気にする必要はなさそう。
・distinfoはmake makesumを実行して生成するのが今の主流らしい。 (ただ、コミットまでに時間が経つとアレなので、TIMESTAMPをちょっと未来のキリがいいところに書き換えちゃってますけどw)

Summary of sentences written in Japanese.
NO_WRKSUBDIR should be used for distfile which doesn't have name-version directory.
PKGINSTALL=${WRKDIR}/pkg-install is automatically assigned, so it is omitted.
Use the name of Readme.txt without changing it.
Use the distinfo file generated by make makesum.
Comment 3 Tatsuki Makino 2022-05-05 06:03:15 UTC
This seems to have been possible to close since ports 81d627688ff76616c6beeb391d26a6cf6bafdfca .
Comment 4 Hiroki Sato freebsd_committer freebsd_triage 2022-05-05 06:26:29 UTC
(In reply to Tatsuki Makino from comment #3)

I am sorry for being unresponsive about this issue for a very long time.  The latest commit should fix the fetch problem as you pointed out.