Bug 241904 - [PATCH] Mk/Uses/php.mk: Stale PHP_VERSION variable prevent to use dependency on mod_php and cgi/fpm/embed checks
Summary: [PATCH] Mk/Uses/php.mk: Stale PHP_VERSION variable prevent to use dependency ...
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-12 04:52 UTC by Dima Panov
Modified: 2019-11-12 08:09 UTC (History)
0 users

See Also:


Attachments
PHP_VERSION -> PHP_VER check (1.72 KB, patch)
2019-11-12 04:52 UTC, Dima Panov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer 2019-11-12 04:52:16 UTC
Created attachment 209084 [details]
PHP_VERSION -> PHP_VER check

Mk/Uses/php.mk: Stale PHP_VERSION variable prevent to use dependency on mod_php and cgi/fpm/embed checks

AFIU, PHP_VERSION should be replaced by PHP_VER by logic
Comment 1 Alex Dupre freebsd_committer 2019-11-12 06:46:24 UTC
Nope, PHP_VERSION is set only when PHP is already installed, and those checks have to be performed only in that case, otherwise you can always install the correct dependencies.
Comment 2 Dima Panov freebsd_committer 2019-11-12 08:03:10 UTC
(In reply to Alex Dupre from comment #1)

In clean environment (poudriere) these checks was always skipped, and no dependency on mod_php/apache registered at all while php:mod or php:web was requested:(
Comment 3 Dima Panov freebsd_committer 2019-11-12 08:09:31 UTC
Oh, I see it. Depend on apache only if it exist in environment. Ok. Sorry for misunderstood