Bug 242079 - games/jumpnbump: fix build on GCC architectures and with threaded builds
Summary: games/jumpnbump: fix build on GCC architectures and with threaded builds
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-19 13:33 UTC by Piotr Kubaj
Modified: 2019-11-21 21:11 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
patch (426 bytes, patch)
2019-11-19 13:33 UTC, Piotr Kubaj
no flags Details | Diff
v2 (425 bytes, patch)
2019-11-19 13:33 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (amdmi3)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-11-19 13:33:00 UTC
Created attachment 209252 [details]
patch

Without USES=compiler:c11:
gfx.c:667: error: expected declaration specifiers or '...' before 'gob_t'
gfx.c:668: warning: conflicting types for 'put_pob'
gfx.c:661: warning: previous implicit declaration of 'put_pob' was here
gfx.c: In function 'put_pob':
gfx.c:679: error: 'gob' undeclared (first use in this function)

Without MAKE_JOBS_UNSAFE=yes:
/usr/local/bin/ld: jnbunpack.o: file not recognized: file truncated                                       collect2: error: ld returned 1 exit status
Comment 1 Piotr Kubaj freebsd_committer 2019-11-19 13:33:55 UTC
Created attachment 209253 [details]
v2

Actually add MAKE_JOBS_UNSAFE=yes.
Comment 2 commit-hook freebsd_committer 2019-11-21 21:10:45 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Nov 21 21:10:39 UTC 2019
New revision: 518113
URL: https://svnweb.freebsd.org/changeset/ports/518113

Log:
  - Fix build on gcc archs by requiring newer compiler

  PR:		242079
  Submitted by:	pkubaj@FreeBSD.org

Changes:
  head/games/jumpnbump/Makefile
Comment 3 Dmitry Marakasov freebsd_committer 2019-11-21 21:11:26 UTC
USES=compiler:c11 committed, MAKE_JOBS_UNSAFE should not be needed after the update, as the build is no longer parallel.