Bug 242141 - games/scid: fix build on arm and powerpc
Summary: games/scid: fix build on arm and powerpc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-21 14:43 UTC by Piotr Kubaj
Modified: 2019-12-06 12:55 UTC (History)
2 users (show)

See Also:
bsd: maintainer-feedback+


Attachments
patch (1.42 KB, patch)
2019-11-21 14:43 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (bsd)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-11-21 14:43:26 UTC
Created attachment 209319 [details]
patch

Explicitly set signed char for variables that are negative to prevent signed/unsigned issue on arm and powerpc.
Comment 1 Friedrich Volkmann 2019-11-21 22:57:47 UTC
This change cannot be wrong, and I think it should be contributed to the scid project as well.
Comment 2 commit-hook freebsd_committer 2019-12-06 12:55:55 UTC
A commit references this bug:

Author: pkubaj
Date: Fri Dec  6 12:55:23 UTC 2019
New revision: 519137
URL: https://svnweb.freebsd.org/changeset/ports/519137

Log:
  games/scid: fix build on arm and powerpc

  Explicitly set signed char for variables that are negative to prevent signed/unsigned issue on arm and powerpc.

  PR:		242141
  Approved by:	bsd@volki.at (maintainer), linimon (mentor)
  Differential Revision:	https://reviews.freebsd.org/D22581

Changes:
  head/games/scid/files/patch-src_fastgame.h