Bug 242168 - [PATCH] misc/openhantek Cleanup pkg-message
Summary: [PATCH] misc/openhantek Cleanup pkg-message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-23 04:38 UTC by Zane C. Bowers-Hadley
Modified: 2019-11-23 05:47 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
pkg-message.diff (734 bytes, patch)
2019-11-23 04:38 UTC, Zane C. Bowers-Hadley
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zane C. Bowers-Hadley 2019-11-23 04:38:44 UTC
Created attachment 209355 [details]
pkg-message.diff

Currently pkg-message shows a specific device path. This changes the devd rules example to show setting the device path in a manner that will always work.

Also no reason to explicitly set the group on the device. User alone will be fine.
Comment 1 Zane C. Bowers-Hadley 2019-11-23 04:41:08 UTC
Also by default there are no group privileges. So explicitly setting the group is also pointless with out also doing chmod.
Comment 2 Yuri Victorovich freebsd_committer 2019-11-23 05:36:38 UTC
Committed, thanks!
Comment 3 commit-hook freebsd_committer 2019-11-23 05:37:10 UTC
A commit references this bug:

Author: yuri
Date: Sat Nov 23 05:36:24 UTC 2019
New revision: 518181
URL: https://svnweb.freebsd.org/changeset/ports/518181

Log:
  misc/openhantek: Cleanup pkg-message

  PR:		242168
  Submitted by:	Zane C. Bowers-Hadley <vvelox@vvelox.net>

Changes:
  head/misc/openhantek/pkg-message
Comment 4 Zane C. Bowers-Hadley 2019-11-23 05:46:53 UTC
Derp. Missed that misc/openhantek already uses openhantek6022.

n/m!
Comment 5 Zane C. Bowers-Hadley 2019-11-23 05:47:26 UTC
ignore last comment, meant for another PR :)