Created attachment 209445 [details]
Do we actually need this (i.e. a documented user request)?
Not a specific user request, but it was on by default until 0.18, and in 0.19 was switched to off, so perhaps someone was using it. Personally I don't care if you want to completely drop it.
Actually I had the full patch to update to 0.19, add the switch and cleanup the port, but when the updated was committed a few minutes before I was able to submit the patch, so I submitted only the remaining parts.
There are some politics with this in bitcoin core: https://news.bitcoin.com/devs-remove-bip70-payment-protocol-from-bitcoin-cores-default-settings/ and it will be gone in the next version.
If a user asks for it I will approve that part of your patch, until then I'd prefer to keep the complexity and churn for the next major down if you don't have a specific need. I am fine with your other changes in this patch if you wish to commit them.
Ok, I agree, I've committed just the cleanup.
A commit references this bug:
Date: Fri Nov 29 09:07:25 UTC 2019
New revision: 518636
Submitted by: ale
Approved by: maintainer