Bug 242245 - net-p2p/bitcoin: add BIP70 option and cleanup
Summary: net-p2p/bitcoin: add BIP70 option and cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-26 08:05 UTC by Alex Dupre
Modified: 2019-11-29 09:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (kbowling)


Attachments
patch (2.18 KB, patch)
2019-11-26 08:05 UTC, Alex Dupre
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Dupre freebsd_committer 2019-11-26 08:05:57 UTC
Created attachment 209445 [details]
patch
Comment 1 Kevin Bowling freebsd_committer 2019-11-29 03:13:59 UTC
Do we actually need this (i.e. a documented user request)?
Comment 2 Alex Dupre freebsd_committer 2019-11-29 06:42:04 UTC
Not a specific user request, but it was on by default until 0.18, and in 0.19 was switched to off, so perhaps someone was using it. Personally I don't care if you want to completely drop it.

Actually I had the full patch to update to 0.19, add the switch and cleanup the port, but when the updated was committed a few minutes before I was able to submit the patch, so I submitted only the remaining parts.
Comment 3 Kevin Bowling freebsd_committer 2019-11-29 08:20:42 UTC
There are some politics with this in bitcoin core:  https://news.bitcoin.com/devs-remove-bip70-payment-protocol-from-bitcoin-cores-default-settings/ and it will be gone in the next version.

If a user asks for it I will approve that part of your patch, until then I'd prefer to keep the complexity and churn for the next major down if you don't have a specific need.  I am fine with your other changes in this patch if you wish to commit them.
Comment 4 Alex Dupre freebsd_committer 2019-11-29 09:07:39 UTC
Ok, I agree, I've committed just the cleanup.
Comment 5 commit-hook freebsd_committer 2019-11-29 09:07:53 UTC
A commit references this bug:

Author: ale
Date: Fri Nov 29 09:07:25 UTC 2019
New revision: 518636
URL: https://svnweb.freebsd.org/changeset/ports/518636

Log:
  Port cleanup.

  PR:		242245
  Submitted by:	ale
  Approved by:	maintainer

Changes:
  head/net-p2p/bitcoin/Makefile
  head/net-p2p/bitcoin/distinfo
  head/net-p2p/bitcoin-daemon/Makefile