Bug 242256 - www/nginx: Build with HTTP_AUTH_KRB5 broken by r518471
Summary: www/nginx: Build with HTTP_AUTH_KRB5 broken by r518471
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-26 19:41 UTC by Christian Ullrich
Modified: 2019-11-28 10:23 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments
patch to fix version (552 bytes, patch)
2019-11-28 08:14 UTC, Pascal Christen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ullrich 2019-11-26 19:41:08 UTC
The latest fix to the www/nginx port updates the external auth_krb5 module to a new Github tag. files/extra-patch-spnego-http-auth-nginx-module-config is not updated and still expects the old commit in the file name, leading to:

    ===>  Applying extra patch /usr/ports/www/nginx/files/extra-patch-spnego-http-auth-nginx-module-config
    No file to patch.  Skipping...

After updating the path in the patch file, the patch applies and the port builds again, but I cannot say whether additional changes to the patch are required.
Comment 1 Dani 2019-11-27 08:46:55 UTC
Confirm, we are also affected by this bug.
Comment 2 Jochen Neumeister freebsd_committer 2019-11-27 08:51:08 UTC
Thanks for the message. I'm still on my way, but I'll take care of the problem tonight. Sorry for the inconvenience.
Comment 3 Pascal Christen 2019-11-28 08:14:17 UTC
Created attachment 209502 [details]
patch to fix version
Comment 4 Pascal Christen 2019-11-28 08:14:39 UTC
same here, guess version change is enough to fix it
Comment 5 commit-hook freebsd_committer 2019-11-28 10:18:01 UTC
A commit references this bug:

Author: joneum
Date: Thu Nov 28 10:17:38 UTC 2019
New revision: 518572
URL: https://svnweb.freebsd.org/changeset/ports/518572

Log:
  - Add support for FreeBSD accept filters [1]
  - Fix build with HTTP_AUTH_KRB5 after r518471 [2]
  - Update 3rd party Modul

  PR:	238739 [1], 242256 [2]
  Sponsored by:	Netzkommune GmbH

Changes:
  head/www/nginx/Makefile
  head/www/nginx/Makefile.extmod
  head/www/nginx/distinfo
  head/www/nginx/files/extra-patch-spnego-http-auth-nginx-module-config
  head/www/nginx/files/nginx.in