Bug 242278 - security/libtasn1: fix build on GCC architectures
Summary: security/libtasn1: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-28 09:00 UTC by Piotr Kubaj
Modified: 2019-11-28 10:38 UTC (History)
1 user (show)

See Also:
novel: maintainer-feedback+


Attachments
patch (325 bytes, patch)
2019-11-28 09:00 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (novel)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-11-28 09:00:17 UTC
Created attachment 209504 [details]
patch

After last update:
corpus2array.c:123: error: 'for' loop initial declaration used outside C99 mode

The attached patch fixes this issue.

This is pretty important, about 5000 ports fail because of this.
Comment 1 Roman Bogorodskiy freebsd_committer 2019-11-28 09:26:46 UTC
Thanks for reporting. Feel free to commit the fix as long as it was build tested.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-11-28 09:29:05 UTC
Approved as mentor.  (I had just now seen this on a build.)
Comment 3 commit-hook freebsd_committer 2019-11-28 10:38:03 UTC
A commit references this bug:

Author: pkubaj
Date: Thu Nov 28 10:37:18 UTC 2019
New revision: 518573
URL: https://svnweb.freebsd.org/changeset/ports/518573

Log:
  security/libtasn1: fix build on GCC architectures

  After last update the port uses C99:
  corpus2array.c:123: error: 'for' loop initial declaration used outside C99 mode

  PR:		242278
  Approved by:	novel (maintainer), linimon (mentor)

Changes:
  head/security/libtasn1/Makefile