Bug 242294 - devel/rubygem-rake: Update to 13.0.2
Summary: devel/rubygem-rake: Update to 13.0.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Fechner
URL: https://github.com/ruby/rake/blob/v13...
Depends on:
Reported: 2019-11-29 08:36 UTC by Yasuhiro Kimura
Modified: 2020-12-19 12:37 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (ruby)

Patch file (769 bytes, patch)
2019-11-29 08:36 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (883 bytes, patch)
2020-12-19 08:53 UTC, Yasuhiro Kimura
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer 2019-11-29 08:36:43 UTC
Created attachment 209524 [details]
Patch file

Update to 13.0.1.
History: https://github.com/ruby/rake/blob/v13.0.1/History.rdoc
Comment 1 Koichiro Iwao freebsd_committer 2019-12-09 08:47:06 UTC
mfechner@, can you confirm this doesn't break your ports such as www/redmine etc?
Comment 2 Matthias Fechner freebsd_committer 2019-12-09 10:30:11 UTC
(In reply to Koichiro Iwao from comment #1)
Have you done a testbuild for the following ports?
Comment 3 Steve Wills freebsd_committer 2019-12-09 13:18:38 UTC
(In reply to Matthias Fechner from comment #2)
I think you may need to do more than build test, you probably need to do run time testing as well, due to the way ruby works.
Comment 4 Koichiro Iwao freebsd_committer 2019-12-10 06:56:18 UTC
(In reply to Matthias Fechner from comment #2)
Yup, succeeded for www/redmine and www/redmine4 but failed www/gitlab-ce.

===> Creating groups.
===> Creating users
cp -f /wrkdirs/usr/ports/www/gitlab-ce/work/gitlab-foss-225d2e5bb899067bde3caedb1319d39c46d94dc0-225d2e5bb899067bde3caed
b1319d39c46d94dc0/config/database.yml.postgresql /wrkdirs/usr/ports/www/gitlab-ce/work/gitlab-foss-225d2e5bb899067bde3ca
(cd /wrkdirs/usr/ports/www/gitlab-ce/work/gitlab-foss-225d2e5bb899067bde3caedb1319d39c46d94dc0-225d2e5bb899067bde3caedb1
319d39c46d94dc0 && /bin/rm -f Gemfile.lock && bundle install --local)
Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
installing your bundle as root will break this application for all non-root
users on this machine.
Resolving dependencies....
Bundler could not find compatible versions for gem "rake":
  In Gemfile:
    derailed_benchmarks was resolved to 1.3.6, which depends on
      rake (> 10, < 13)

    grape-path-helpers (~> 1.1) was resolved to 1.1.0, which depends on
      rake (~> 12)

Could not find gem 'rake (~> 12)', which is required by gem
'derailed_benchmarks', in any of the sources.
*** Error code 6

make: stopped in /usr/ports/www/gitlab-ce
build of www/gitlab-ce | gitlab-ce-12.5.3 ended at Tue Dec 10 15:32:00 JST 2019
build time: 00:02:14
!!! build failure encountered !!!
[01:12:20] Error: Build failed in phase: stage
[01:12:20] Cleaning up
[01:12:20] Unmounting file systems
sudo poudriere testport -j 12amd64 -p custom www/gitlab-ce  6372.69s user 3472.81s system 226% cpu 1:12:20.87 total
Comment 5 Koichiro Iwao freebsd_committer 2019-12-10 06:57:34 UTC
If no other ports requires rake 13, maybe we can postpone updating to 13 until it is really required.
Comment 6 Matthias Fechner freebsd_committer 2019-12-10 09:50:19 UTC
Thanks for the test.

I suggest also to wait till one of the big ports (gitlab-ce, redmine) is requiring this update.
Comment 7 Yasuhiro Kimura freebsd_committer 2020-12-19 08:53:48 UTC
Created attachment 220709 [details]
Updated patch file

New version 13.0.2 is released.
Comment 8 Matthias Fechner freebsd_committer 2020-12-19 10:01:19 UTC
The problem with gitlab is fixed, build is successful (and yes, gitlab and redmine4 will fail, they do a runtime check at buildtime):

I will run now a bigger build to see if other packages are working:

After this is done, I will commit the update.
Comment 9 commit-hook freebsd_committer 2020-12-19 12:37:03 UTC
A commit references this bug:

Author: mfechner
Date: Sat Dec 19 12:36:25 UTC 2020
New revision: 558448
URL: https://svnweb.freebsd.org/changeset/ports/558448

  Update to 13.0.2.

  PR:		242294
  Submitted by:	yasu@utahime.org

Comment 10 Matthias Fechner freebsd_committer 2020-12-19 12:37:24 UTC
Committed, thanks!