Bug 242342 - lang/rust-nightly: make makesum doesn't respect ONLY_FOR_ARCHS
Summary: lang/rust-nightly: make makesum doesn't respect ONLY_FOR_ARCHS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Rust Team
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2019-12-01 17:45 UTC by Jan Beich
Modified: 2019-12-02 04:19 UTC (History)
0 users

See Also:
tobik: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2019-12-01 17:45:54 UTC
When updating the port I've noticed that makesum checks files for architectures only supported by lang/rust.

$ make makesum -C lang/rust-nightly
make -D_RUST_MAKESUM_GUARD makesum ARCH=amd64 DISTINFO_FILE=/usr/ports/lang/rust-nightly/distinfo.tmp
===>  License APACHE20 MIT accepted by the user
===>  License APACHE20 MIT accepted by the user
===>   rust-nightly-1.41.0.20191130 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by rust-nightly-1.41.0.20191130 for building
make -D_RUST_MAKESUM_GUARD makesum PPC_ABI=ELFv1 ARCH=i386 DISTINFO_FILE=/usr/ports/lang/rust-nightly/distinfo.i386
===>  License APACHE20 MIT accepted by the user
===>  License APACHE20 MIT accepted by the user
===>   rust-nightly-1.41.0.20191130 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by rust-nightly-1.41.0.20191130 for building
/usr/bin/grep i686 /usr/ports/lang/rust-nightly/distinfo.i386 >> /usr/ports/lang/rust-nightly/distinfo.tmp
/bin/rm -f /usr/ports/lang/rust-nightly/distinfo.i386
make -D_RUST_MAKESUM_GUARD makesum PPC_ABI=ELFv2 ARCH=powerpc64 DISTINFO_FILE=/usr/ports/lang/rust-nightly/distinfo.powerpc64-elfv2
===>  rust-nightly-1.41.0.20191130 is missing a bootstrap for FreeBSD 11.x
powerpc64.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/lang/rust-nightly
*** Error code 1

Stop.
make: stopped in /usr/ports/lang/rust-nightly
Comment 1 commit-hook freebsd_committer 2019-12-01 18:37:17 UTC
A commit references this bug:

Author: tobik
Date: Sun Dec  1 18:36:53 UTC 2019
New revision: 518792
URL: https://svnweb.freebsd.org/changeset/ports/518792

Log:
  lang/rust: Respect ONLY_FOR_ARCHS in makesum

  lang/rust-nightly does not have powerpc64 in it and unconditionally
  running makesum for the powerpc64 ELFv2 bootstraps breaks there.

  PR:		242342
  Reported by:	jbeich

Changes:
  head/lang/rust/Makefile
Comment 2 Tobias Kortkamp freebsd_committer 2019-12-02 04:19:41 UTC
Should be fixed.