Bug 242351 - x11-themes/papirus-icon-theme: update to 20191201
Summary: x11-themes/papirus-icon-theme: update to 20191201
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://github.com/PapirusDevelopment...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-02 07:06 UTC by Hiroki Tagato
Modified: 2019-12-06 19:50 UTC (History)
0 users

See Also:


Attachments
Gzipped patch (189.63 KB, application/gzip)
2019-12-02 07:06 UTC, Hiroki Tagato
tagattie: maintainer-approval+
Details
Gzipped patch (rev. 1) (408.03 KB, application/gzip)
2019-12-06 11:49 UTC, Hiroki Tagato
tagattie: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-12-02 10:00:17 UTC
The plist size is ridiculous.  Consider adding something like

post-install:
	@cd ${PREFIX} && ${FIND} share/icons -type f >> ${TMPPLIST}

to remove the need for one.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-12-02 10:03:15 UTC
(In reply to Tobias Kortkamp from comment #1)

I meant

post-install:
	@cd ${STAGEDIR}${PREFIX} && ${FIND} share/icons -type f >> ${TMPPLIST}
Comment 3 Hiroki Tagato freebsd_committer freebsd_triage 2019-12-06 11:49:50 UTC
Created attachment 209755 [details]
Gzipped patch (rev. 1)
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2019-12-06 11:50:57 UTC
(In reply to Tobias Kortkamp from comment #2)

Thanks Tobias for the comments.

I have updated the patch as per your suggestion.
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2019-12-06 19:49:51 UTC
Committed. Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-12-06 19:50:28 UTC
A commit references this bug:

Author: tobik
Date: Fri Dec  6 19:49:39 UTC 2019
New revision: 519160
URL: https://svnweb.freebsd.org/changeset/ports/519160

Log:
  x11-themes/papirus-icon-theme: Update to 20191201

  Delete pkg-plist and dynamically generate the plist instead to ease
  future updates.  pkg-plist was 4.1 MiB large and had over 70000
  entries.  This also bloated the patch accordingly to the point it
  had to be gzipped to not go over Bugzilla's size limit for attachments.
  It was still over 100 KiB compressed.

  Changes:	https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/releases
  PR:		242351
  Submitted by:	Hiroki Tagato <tagattie@yandex.com> (maintainer)

Changes:
  head/x11-themes/papirus-icon-theme/Makefile
  head/x11-themes/papirus-icon-theme/distinfo
  head/x11-themes/papirus-icon-theme/pkg-plist