Bug 242398 - audio/grip Update to 4.0.1
Summary: audio/grip Update to 4.0.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-03 08:40 UTC by Jens Grassel
Modified: 2019-12-10 11:43 UTC (History)
1 user (show)

See Also:
freebsd-ports: maintainer-feedback+


Attachments
Patch to update audio/grip to version 4.0.1 (748 bytes, patch)
2019-12-03 08:40 UTC, Jens Grassel
no flags Details | Diff
Update audio/grip to 4.0.1 (2.12 KB, patch)
2019-12-05 17:01 UTC, Jens Grassel
no flags Details | Diff
Update audio/grip to 4.0.1 (2.56 KB, patch)
2019-12-05 19:14 UTC, Jens Grassel
no flags Details | Diff
Update audio/grip to 4.0.1 (2.00 KB, patch)
2019-12-09 15:07 UTC, Jens Grassel
no flags Details | Diff
Update audio/grip to 4.0.1 (1.98 KB, patch)
2019-12-09 20:13 UTC, Jens Grassel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Grassel 2019-12-03 08:40:57 UTC
Created attachment 209645 [details]
Patch to update audio/grip to version 4.0.1

Hi,

I've attached a patch to update audio/grip to the latest version (4.0.1).

### Changelog

#### v4.0.1

* Patch from Dan Fandrich: 
  - Stop copying overlapping strings on multi-artist CDs
* Add korean translation from TP
* nl.po, zh_CN.po: Update translations from TP

#### v4.0.0

* Patches from Adrian Reber:
  - Remove vte dependency
     grip uses vte for its status window. The version of vte grip relies on
     is not maintained upstream for a long time. This commit removes the
     complete status window functionality from grip. Messages previously sent
     to the status window are now sent to the console.
  - Switch to non-deprecated g_string functions
  - Ignore deprecation errors

Kind regards,

Jens
Comment 1 Dmitry Marakasov freebsd_committer 2019-12-05 15:34:35 UTC
Please test the port properly. Plist is incomplete.
Comment 2 Jens Grassel 2019-12-05 17:01:25 UTC
Created attachment 209730 [details]
Update audio/grip to 4.0.1

Sorry for the inconvenience, I updated the patch with the corrected plist.
Comment 3 Dmitry Marakasov freebsd_committer 2019-12-05 18:38:11 UTC
(In reply to Jens Grassel from comment #2)
Again, please test before submission. Plist is incorrect, it should not include licenses.
Comment 4 Jens Grassel 2019-12-05 19:14:31 UTC
Created attachment 209739 [details]
Update audio/grip to 4.0.1

Removed license files from pkg-plist.
Comment 5 Dmitry Marakasov freebsd_committer 2019-12-05 20:35:05 UTC
USES change introduces Makefile warnings.
Comment 6 Jens Grassel 2019-12-08 09:48:01 UTC
Do you mean the portlint warning?

WARN: Makefile: possible use of absolute pathname "/dev/somedevice\".

That was there from the day I took over the port and I have no idea how to fix it.

Regards,

Jens
Comment 7 Dmitry Marakasov freebsd_committer 2019-12-09 14:19:00 UTC
(In reply to Jens Grassel from comment #6)

No, I mean

% DEVELOPER=yes make checksum
===> The default CDROM device is /dev/cd0
===> Define WITH_CDROM_DEVICE if you want to change the default
===> For example, 'make WITH_CDROM_DEVICE="/dev/somedevice"'
/!\ grip-4.0.1: Makefile warnings, please consider fixing /!\

Using USE_XORG alone is deprecated, please use USES=xorg

Using USE_GNOME alone is deprecated, please add USES=gnome.


Sorry, I forgot that it requires DEVELOPER=yes. I suggest to put it into your /etc/make.conf
Comment 8 Jens Grassel 2019-12-09 15:07:14 UTC
Created attachment 209802 [details]
Update audio/grip to 4.0.1

Hi,

thanks for the hint.
Hopefully now everything is right.

Regards,

Jens
Comment 9 Dmitry Marakasov freebsd_committer 2019-12-09 19:27:49 UTC
The patch does not apply - it seems to be made against other port versions than we currently have in the portstree.
Comment 10 Jens Grassel 2019-12-09 20:13:16 UTC
Created attachment 209809 [details]
Update audio/grip to 4.0.1

Oh my, I should stop making these _after_ work. ;-)

It should work now and again sorry for the inconvenience.

Kind regards,

Jens
Comment 11 commit-hook freebsd_committer 2019-12-10 11:42:07 UTC
A commit references this bug:

Author: amdmi3
Date: Tue Dec 10 11:41:48 UTC 2019
New revision: 519660
URL: https://svnweb.freebsd.org/changeset/ports/519660

Log:
  - Update to 4.0.1

  PR:		242398
  Submitted by:	freebsd-ports@jan0sch.de (maintainer)

Changes:
  head/audio/grip/Makefile
  head/audio/grip/distinfo
  head/audio/grip/pkg-plist
Comment 12 Dmitry Marakasov freebsd_committer 2019-12-10 11:43:18 UTC
This time it's good, thanks!