Bug 242404 - www/node: fix build on powerpc64 elfv1
Summary: www/node: fix build on powerpc64 elfv1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Only Me
Assignee: Bradley T. Hughes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-03 13:07 UTC by Piotr Kubaj
Modified: 2019-12-13 10:21 UTC (History)
2 users (show)

See Also:
bhughes: maintainer-feedback+


Attachments
patch (2.69 KB, patch)
2019-12-03 13:07 UTC, Piotr Kubaj
bhughes: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-12-03 13:07:09 UTC
Created attachment 209652 [details]
patch

13.2.0 broke powerpc64 elfv1 (again). The problem are those two commits:
https://github.com/nodejs/node/commit/605cb9f0fcd1d334ec15959bb79ba44b0e9f8186
https://github.com/nodejs/node/commit/fe99841c88fdb87959a14c7bca81e4cd4582eba6

They added ifdefs for _AIX, but the code they guard should run on all ppc64 elfv1 (not only on AIX).

Widen those ifdefs appriopriately so that node builds again.
Comment 1 commit-hook freebsd_committer 2019-12-13 10:19:46 UTC
A commit references this bug:

Author: pkubaj
Date: Fri Dec 13 10:19:05 UTC 2019
New revision: 520012
URL: https://svnweb.freebsd.org/changeset/ports/520012

Log:
  www/node: fix build on powerpc64 elfv1

  13.2.0 broke powerpc64 elfv1 (again). The problem are those two commits:
  https://github.com/nodejs/node/commit/605cb9f0fcd1d334ec15959bb79ba44b0e9f8186
  https://github.com/nodejs/node/commit/fe99841c88fdb87959a14c7bca81e4cd4582eba6

  They added ifdefs for _AIX, but the code they guard should run on all ppc64 elfv1 (not only on AIX).

  Widen those ifdefs appriopriately so that node builds again.

  PR:		242404
  Approved by:	bhughes (maintainer)

Changes:
  head/www/node/files/patch-deps_v8_src_compiler_backend_instruction-selector.cc
  head/www/node/files/patch-deps_v8_src_compiler_backend_ppc_code-generator-ppc.cc