Bug 242422 - security/onionscan: Unbreak on aarch64
Summary: security/onionscan: Unbreak on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Vinícius Zavam
URL:
Keywords:
Depends on:
Blocks: 242312
  Show dependency tree / graph
 
Reported: 2019-12-04 12:51 UTC by Dmitri Goutnik
Modified: 2019-12-09 12:21 UTC (History)
1 user (show)

See Also:
egypcio: maintainer-feedback+

Attachments
onionscan-0.2_2.patch (1.79 KB, patch)
2019-12-04 12:51 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (egypcio)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-12-04 12:51:02 UTC 
Created attachment 209687 [details]
onionscan-0.2_2.patch

===>  Building onionscan from github.com/s-rah/onionscan
# github.com/s-rah/onionscan/vendor/golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/cap_freebsd.go:18:23: undefined: CAP_RIGHTS_VERSION_00
vendor/golang.org/x/sys/unix/cap_freebsd.go:19:23: undefined: CAP_RIGHTS_VERSION_00
vendor/golang.org/x/sys/unix/cap_freebsd.go:46:21: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:50:24: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:55:27: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:90:29: undefined: CapRights
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:12:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:13:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:14:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:15:6: missing function body

http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518178_s355024/logs/errors/onionscan-0.2_1.log

Unbreak by updating golang.org/x/sys to 33540a1f6037 which adds support for freebsd/arm64.

Tested on 12.1-STABLE/arm64 and 12.1-RELEASE/amd64.
Comment 1 Vinícius Zavam freebsd_committer freebsd_triage 2019-12-04 18:05:41 UTC 
cool stuff! thanks for reporting and patching, appreciated.

should I keep the default of using 7-digits for the tag in those GH_TUPLE lines? that's the only modification I would do before committing it to the tree. works for you?

right now I (sadly) do not have an aarch64 hardware/jail to test it :"(
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2019-12-04 18:18:51 UTC 
(In reply to Vinícius Zavam from comment #1)
7 digits commit ID should be fine. I used 12 because this is what modules2tuple outputs.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-12-09 12:20:17 UTC 
A commit references this bug:

Author: egypcio
Date: Mon Dec  9 12:19:30 UTC 2019
New revision: 519603
URL: https://svnweb.freebsd.org/changeset/ports/519603

Log:
  security/onionscan: Unbreak on aarch64

  PR:		242422
  Submitted by:	dmgk@

Changes:
  head/security/onionscan/Makefile
  head/security/onionscan/distinfo
Comment 4 Vinícius Zavam freebsd_committer freebsd_triage 2019-12-09 12:21:13 UTC 
cool; committed! thanks.
I did ran `makesum` again to regen distinfo's stuff