Bug 242446 - shells/antibody: Unbreak on aarch64
Summary: shells/antibody: Unbreak on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks: 242312
  Show dependency treegraph
 
Reported: 2019-12-05 11:55 UTC by Dmitri Goutnik
Modified: 2019-12-05 17:08 UTC (History)
1 user (show)

See Also:
adamw: maintainer-feedback+


Attachments
antibody-4.2.0_2.patch (1.71 KB, patch)
2019-12-05 11:55 UTC, Dmitri Goutnik
dmgk: maintainer-approval? (adamw)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2019-12-05 11:55:58 UTC
Created attachment 209718 [details]
antibody-4.2.0_2.patch

===>  Building antibody from .
# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/cap_freebsd.go:18:23: undefined: CAP_RIGHTS_VERSION_00
vendor/golang.org/x/sys/unix/cap_freebsd.go:19:23: undefined: CAP_RIGHTS_VERSION_00
vendor/golang.org/x/sys/unix/cap_freebsd.go:46:21: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:50:24: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:55:27: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:90:29: undefined: CapRights
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:12:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:13:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:14:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:15:6: missing function body

http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518178_s355024/logs/errors/antibody-4.2.0_1.log

Unbreak by updating golang.org/x/sys to 33540a1f6037 which adds support for freebsd/arm64.

Tested on 12.1-STABLE/arm64 and 12.1-RELEASE/amd64.
Comment 1 Adam Weinberger freebsd_committer 2019-12-05 11:58:29 UTC
I haven't tested this (nor can I), but I trust you. If you have any patches like this (fixing ports on various archs) in the future for any of my other ports, please go ahead with my implicit approval.
Comment 2 commit-hook freebsd_committer 2019-12-05 17:05:33 UTC
A commit references this bug:

Author: dmgk
Date: Thu Dec  5 17:05:13 UTC 2019
New revision: 519095
URL: https://svnweb.freebsd.org/changeset/ports/519095

Log:
  shells/antibody: Unbreak on aarch64

  ===>  Building antibody from .
  # golang.org/x/sys/unix
  vendor/golang.org/x/sys/unix/cap_freebsd.go:18:23: undefined: CAP_RIGHTS_VERSION_00
  vendor/golang.org/x/sys/unix/cap_freebsd.go:19:23: undefined: CAP_RIGHTS_VERSION_00
  vendor/golang.org/x/sys/unix/cap_freebsd.go:46:21: undefined: CapRights
  vendor/golang.org/x/sys/unix/cap_freebsd.go:50:24: undefined: CapRights
  vendor/golang.org/x/sys/unix/cap_freebsd.go:55:27: undefined: CapRights
  vendor/golang.org/x/sys/unix/cap_freebsd.go:90:29: undefined: CapRights
  vendor/golang.org/x/sys/unix/syscall_unix_gc.go:12:6: missing function body
  vendor/golang.org/x/sys/unix/syscall_unix_gc.go:13:6: missing function body
  vendor/golang.org/x/sys/unix/syscall_unix_gc.go:14:6: missing function body
  vendor/golang.org/x/sys/unix/syscall_unix_gc.go:15:6: missing function body

  http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518178_s355024/logs/errors/antibody-4.2.0_1.log

  Unbreak by updating golang.org/x/sys to 33540a1f6037 which adds support for
  freebsd/arm64.

  PR:		242446
  Approved by:	adamw (maintainer)

Changes:
  head/shells/antibody/Makefile
  head/shells/antibody/distinfo