Bug 242449 - sysutils/kops: Unbreak on aarch64
Summary: sysutils/kops: Unbreak on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks: 242312
  Show dependency tree / graph
 
Reported: 2019-12-05 12:33 UTC by Dmitri Goutnik
Modified: 2019-12-15 15:48 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danilo)

Attachments
kops-1.15.0_1.patch (2.20 KB, patch)
2019-12-05 12:33 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (danilo)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-12-05 12:33:06 UTC 
Created attachment 209721 [details]
kops-1.15.0_1.patch

===>  Building kops from k8s.io/kops/cmd/kops
# k8s.io/kops/vendor/golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/cap_freebsd.go:18:23: undefined: CAP_RIGHTS_VERSION_00
vendor/golang.org/x/sys/unix/cap_freebsd.go:19:23: undefined: CAP_RIGHTS_VERSION_00
vendor/golang.org/x/sys/unix/cap_freebsd.go:46:21: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:50:24: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:55:27: undefined: CapRights
vendor/golang.org/x/sys/unix/cap_freebsd.go:90:29: undefined: CapRights
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:12:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:13:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:14:6: missing function body
vendor/golang.org/x/sys/unix/syscall_unix_gc.go:15:6: missing function body

http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518178_s355024/logs/errors/kops-1.14.0.log

Unbreak by updating golang.org/x/sys to 33540a1f6037 which adds support for freebsd/arm64.

Tested on 12.1-STABLE/arm64 and 12.1-RELEASE/amd64.
Comment 1 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2019-12-15 12:39:59 UTC 
Hi, I've tested building this port without the patch and it works for me.

I've tried on CURRENT (13.0-CURRENT r355713) and 12.1-RELEASE on an aarch64 AWS EC2 virtual machine.

In fact, the binary is available via pkg:

# pkg search kops
kops-1.15.0                    Kubernetes Operations

In which situation does it fail for you?
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2019-12-15 13:55:42 UTC 
http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518178_s355024/logs/errors/kops-1.14.0.log

Perhaps the issue was fixed in 1.15.0 in which case this PR can be closed.
Comment 3 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2019-12-15 15:48:41 UTC 
Alright, closing. Thank you!