Bug 242474 - databases/mysql57-server and databases/mysql57-client: version 5.7.28 does not build with libressl
Summary: databases/mysql57-server and databases/mysql57-client: version 5.7.28 does no...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-06 08:46 UTC by Walter Schwarzenfeld
Modified: 2019-12-07 18:00 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mmokhi)


Attachments
proposed change of patch-cmake_ssl.cmake (1.76 KB, patch)
2019-12-06 10:57 UTC, Walter Schwarzenfeld
no flags Details | Diff
proposed change of patch-client-cmake_ssl.cmake (1.74 KB, patch)
2019-12-06 21:09 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2019-12-06 08:46:20 UTC
Mysql57-server and client Version 5.7.28  does not build with libressl.

Both the same error:

/ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c
/ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c:505:27: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
                        | SSL_OP_NO_TLSv1_3
                          ^
/ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c:538:23: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
                    | SSL_OP_NO_TLSv1_3
                      ^
/ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c:564:12: warning: implicit declaration of function 'SSL_CTX_set_ciphersuites' is invalid in C99 [-Wimplicit-function-declaration]
  if (0 == SSL_CTX_set_ciphersuites(ssl_fd->ssl_context, ""))
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-12-06 09:00:57 UTC
mysql57-server have more errors:

/ram/usr/ports/databases/mysql57-server/work/mysql-5.7.28/rapid/plugin/group_replication/libmysqlgcs/src/bindings/xcom/xcom/xcom_ssl_transport.c:237:61: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
  long ssl_ctx_options= SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_TLSv1_3;
                                                            ^
/ram/usr/ports/databases/mysql57-server/work/mysql-5.7.28/rapid/plugin/group_replication/libmysqlgcs/src/bindings/xcom/xcom/xcom_ssl_transport.c:261:23: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
                    | SSL_OP_NO_TLSv1_3
                      ^
/ram/usr/ports/databases/mysql57-server/work/mysql-5.7.28/rapid/plugin/group_replication/libmysqlgcs/src/bindings/xcom/xcom/xcom_ssl_transport.c:270:7: warning: implicit declaration of function 'SSL_CTX_set_ciphersuites' is invalid in C99 [-Wimplicit-function-declaration]
  if (SSL_CTX_set_ciphersuites(ssl_ctx, "") == 0)
Comment 3 Walter Schwarzenfeld freebsd_triage 2019-12-06 10:57:45 UTC
Created attachment 209753 [details]
proposed change of patch-cmake_ssl.cmake
Comment 4 Walter Schwarzenfeld freebsd_triage 2019-12-06 10:58:31 UTC
Patch is for the mysql57-server.
Comment 5 commit-hook freebsd_committer 2019-12-06 19:03:24 UTC
A commit references this bug:

Author: joneum
Date: Fri Dec  6 19:02:44 UTC 2019
New revision: 519158
URL: https://svnweb.freebsd.org/changeset/ports/519158

Log:
  /ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c
  /ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c:505:27: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
                          | SSL_OP_NO_TLSv1_3

  This fix a problem with libressl

  PR:		242474
  Approved by:	mmokhi (maintainer, implicit)
  Sponsored by:	Netzkommune GmbH

Changes:
  head/databases/mysql57-server/Makefile
  head/databases/mysql57-server/files/patch-cmake_ssl.cmake
Comment 6 Walter Schwarzenfeld freebsd_triage 2019-12-06 21:09:54 UTC
Created attachment 209767 [details]
proposed change of patch-client-cmake_ssl.cmake
Comment 7 Walter Schwarzenfeld freebsd_triage 2019-12-06 21:10:24 UTC
Client still fails with:

/ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c:505:27: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
                        | SSL_OP_NO_TLSv1_3
                          ^
/ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c:538:23: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
                    | SSL_OP_NO_TLSv1_3
                      ^
/ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c:564:12: warning: implicit declaration of function 'SSL_CTX_set_ciphersuites' is invalid in C99 [-Wimplicit-function-declaration]
  if (0 == SSL_CTX_set_ciphersuites(ssl_fd->ssl_context, ""))
Comment 8 Walter Schwarzenfeld freebsd_triage 2019-12-06 21:12:16 UTC
re-open.
Comment 9 Jochen Neumeister freebsd_committer 2019-12-06 21:19:08 UTC
I'm afraid I don't have time to take care of this right now.
A patch is welcome.
Comment 10 Walter Schwarzenfeld freebsd_triage 2019-12-06 21:28:40 UTC
See comment6.
Comment 11 commit-hook freebsd_committer 2019-12-07 17:56:54 UTC
A commit references this bug:

Author: joneum
Date: Sat Dec  7 17:55:57 UTC 2019
New revision: 519226
URL: https://svnweb.freebsd.org/changeset/ports/519226

Log:
  /ram/usr/ports/databases/mysql57-client/work/mysql-5.7.28/vio/viosslfactories.c:505:27: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
                          | SSL_OP_NO_TLSv1_3

  This patch fix this error

  PR:		242474
  Approved by:	mmokhi (maintainer, implicit)
  Sponsored by:	Netzkommune GmbH

Changes:
  head/databases/mysql57-client/Makefile
  head/databases/mysql57-client/files/patch-cmake_ssl.cmake