Bug 242478 - net/samba410: cmocka RUN_DEPENDS
Summary: net/samba410: cmocka RUN_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-06 11:18 UTC by michal
Modified: 2020-04-05 20:38 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (timur)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description michal 2019-12-06 11:18:49 UTC
Makefile for net/samba410 contains this line:

RUN_DEPENDS+=                   cmocka>=1.1.3:sysutils/cmocka

sysutils/cmocka being the unit testing framework for C, isn't it sufficient for samba to build? Is it really required for it to run?
Comment 1 michal 2019-12-12 09:18:22 UTC
(In reply to michal from comment #0)

Let me rephrase my question. Is cmocka really required as a run dependency?
Comment 2 Timur I. Bakeyev freebsd_committer 2019-12-12 11:09:49 UTC
(In reply to michal from comment #1)

I got the question, sure.

Las time when I was making the port one or two binaries were linked to this library, so it was necessary.

But, TBH, I haven't checked this linkage for 4.10, so maybe, it's not necessary anymore. Or the binary can be removed from the package, 99% is that was smbtorture, which isn't commonly used.
Comment 3 michal 2019-12-14 08:36:24 UTC
(In reply to Timur I. Bakeyev from comment #2)

On my installation, none of the binaries and libs installed by net/samba410 seems to be dynamically linked to libcmocka.so. Not even smbtorture.

# ldd /usr/local/bin/smbtorture | grep cmocka | wc -l
       0

I'll try to rebuild net/samba410 with that RUN_DEPENDS line commented out. Will let you know the result if interested.
Comment 4 michal 2019-12-15 16:20:57 UTC
(In reply to michal from comment #3)

So I commented the line RUN_DEPENDS+=cmocka>=1.1.3:sysutils/cmocka and did full package rebuild and reinstall. So far everything seems to be working okay. net/samba410 on my system is configured as follows:

# cat /var/db/ports/net_samba410/options 
# This file is auto-generated by 'make config'.
# Options for samba410-4.10.11
_OPTIONS_READ=samba410-4.10.11
_FILE_COMPLETE_OPTIONS_LIST=ADS AD_DC AESNI CLUSTER CUPS DEBUG DEVELOPER DOCS FAM GPGME LDAP MANDOC NTVFS PROFILE QUOTAS SPOTLIGHT SYSLOG UTMP GSSAPI_BUILTIN GSSAPI_MIT ZEROCONF_NONE AVAHI MDNSRESPONDER NSUPDATE BIND911 BIND914 FRUIT GLUSTERFS
OPTIONS_FILE_UNSET+=ADS
OPTIONS_FILE_UNSET+=AD_DC
OPTIONS_FILE_SET+=AESNI
OPTIONS_FILE_UNSET+=CLUSTER
OPTIONS_FILE_UNSET+=CUPS
OPTIONS_FILE_UNSET+=DEBUG
OPTIONS_FILE_UNSET+=DEVELOPER
OPTIONS_FILE_UNSET+=DOCS
OPTIONS_FILE_SET+=FAM
OPTIONS_FILE_UNSET+=GPGME
OPTIONS_FILE_UNSET+=LDAP
OPTIONS_FILE_UNSET+=MANDOC
OPTIONS_FILE_UNSET+=NTVFS
OPTIONS_FILE_UNSET+=PROFILE
OPTIONS_FILE_SET+=QUOTAS
OPTIONS_FILE_UNSET+=SPOTLIGHT
OPTIONS_FILE_SET+=SYSLOG
OPTIONS_FILE_SET+=UTMP
OPTIONS_FILE_SET+=GSSAPI_BUILTIN
OPTIONS_FILE_UNSET+=GSSAPI_MIT
OPTIONS_FILE_UNSET+=ZEROCONF_NONE
OPTIONS_FILE_SET+=AVAHI
OPTIONS_FILE_UNSET+=MDNSRESPONDER
OPTIONS_FILE_UNSET+=NSUPDATE
OPTIONS_FILE_UNSET+=BIND911
OPTIONS_FILE_UNSET+=BIND914
OPTIONS_FILE_SET+=FRUIT
OPTIONS_FILE_UNSET+=GLUSTERFS
Comment 5 Timur I. Bakeyev freebsd_committer 2020-04-05 20:38:47 UTC
Ok, I made thorough enough analysis of the include packages and delendencies, it looks like indeed, cmocka isn't required for the normal run of the Samba, only for the tests. Still it is necessary for the BUILD stage.

So should be it, no RUN_DEPENDS for cmocka.

Thank you for your report!