Bug 242487 - archivers/amigadepacker: switch from sed to patch
Summary: archivers/amigadepacker: switch from sed to patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-06 17:22 UTC by Steve Wills
Modified: 2019-12-07 08:31 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
patch for amigadepacker (1.01 KB, patch)
2019-12-06 17:22 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer 2019-12-06 17:22:02 UTC
Created attachment 209762 [details]
patch for amigadepacker

Per section 4.4.3 of the Porters Handbook, REINPLACE_CMD (sed) should not be used to replace static content. See attached patch.
Comment 1 commit-hook freebsd_committer 2019-12-07 08:31:02 UTC
A commit references this bug:

Author: ehaupt
Date: Sat Dec  7 08:30:15 UTC 2019
New revision: 519189
URL: https://svnweb.freebsd.org/changeset/ports/519189

Log:
  Per section 4.4.3 of the Porters Handbook, REINPLACE_CMD (sed) should not be
  used to replace static content.

  Switch from sed to patch.

  PR:		242487
  Submitted by:	swills

Changes:
  head/archivers/amigadepacker/Makefile
  head/archivers/amigadepacker/files/
  head/archivers/amigadepacker/files/patch-Makefile.in
Comment 2 Emanuel Haupt freebsd_committer 2019-12-07 08:31:16 UTC
Committed, thank you.