Bug 242529 - audio/gstreamer1-plugins-lame and other consumers of lame: missing dependency on lame, add mention to pkg-message
Summary: audio/gstreamer1-plugins-lame and other consumers of lame: missing dependency...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-12-09 20:16 UTC by PauAmma
Modified: 2021-04-16 20:04 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)
koobs: merge-quarterly?


Attachments
Add "install audio/lame" package messages (52.60 KB, patch)
2020-08-29 21:59 UTC, PauAmma
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description PauAmma freebsd_triage 2019-12-09 20:16:33 UTC
I installed audio/gstreamer1-plugins-lame (as required by xfce4-goodies -> xfburn) from pkg (probably sometime between when 12.1-RC2 came out and the release of 12.1 itself), and some time thereafter, I started getting a "pkg: gstreamer1-plugins-lame has a missing dependency: lame" message. I think this means that at some point lame (as a package) disappeared from under gstreamer1-plugins-lame. More information available upon request.
Comment 1 PauAmma freebsd_triage 2019-12-10 19:50:52 UTC
The discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242528 looks relevant to this PR as well, so perhaps the solution is similar: a pkg-message for audio/gstreamer1-plugins-lame with install and remove messages. I'm unsure, however, where that pkg-message would live: in the slave port or the master port multimedia/gstreamer1-plugins.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-02 22:36:11 UTC
Per bug 228441 until we enable packaging of lame, a pkg-message may be the best UX option we have in the meantime. If there is otherwise no other change proposal intended here (except enabling lame packaging), please include a patch to add a pkg-message accordingly, per ports r520114 (via Kai, cc'd)
Comment 3 PauAmma freebsd_triage 2020-08-29 16:19:38 UTC
Affected packages, based on "pkg rquery -a '%o %do' | grep audio/lame | sort":
audio/abcde, audio/aqualung, audio/atunes, audio/cd2mp3, audio/gnormalize, audio/gstreamer-plugins-lame, audio/gstreamer1-plugins-lame, audio/mous, audio/musescore, audio/mythplugin-mythmusic, audio/normalize, audio/ogg2mp3, audio/osalp, audio/pacpl, audio/rezound, audio/ripit, audio/streamtranscoder, audio/xmcd, comms/ebook2cw, emulators/vice, games/scummvm-tools, multimedia/butt, multimedia/handbrake, multimedia/iso2mkv, multimedia/libquicktime-lame, multimedia/mencode, multimedia/musikcube, multimedia/mythtv, multimedia/mythtv-frontend, multimedia/ogmrip, multimedia/tovid, multimedia/transcode, sysutils/fusefs-mp3fs, sysutils/k3b, sysutils/mybashburn, sysutils/xvidcap.
Comment 4 PauAmma freebsd_triage 2020-08-29 21:59:16 UTC
Created attachment 217630 [details]
Add "install audio/lame" package messages

svn add audio/aqualung/pkg-message audio/atunes/pkg-message audio/cd2mp3/pkg-message audio/gnormalize/pkg-message audio/gstreamer-plugins-lame/pkg-message audio/gstreamer1-plugins-lame/pkg-message audio/musescore/pkg-message audio/mythplugin-mythmusic/pkg-message audio/normalize/pkg-message audio/ogg2mp3/pkg-message audio/osalp/pkg-message audio/pacpl/pkg-message audio/rezound/pkg-message audio/streamtranscoder/pkg-message comms/ebook2cw/pkg-message games/scummvm-tools/pkg-message multimedia/butt/pkg-message multimedia/handbrake/pkg-message multimedia/iso2mkv/pkg-message multimedia/libquicktime-lame/pkg-message multimedia/mencoder/pkg-message multimedia/musikcube/pkg-message multimedia/mythtv/pkg-message-frontend multimedia/tovid/pkg-message multimedia/transcode/pkg-message sysutils/fusefs-mp3fs/pkg-message sysutils/mybashburn/pkg-message sysutils/xvidcap/pkg-message

Tested by building each port and checking the message was displayed.
Comment 5 PauAmma freebsd_triage 2020-09-19 17:58:13 UTC
CC'ing portmgr@ at Zeising's direction in IRC, to try moving this forward.
Comment 6 Niclas Zeising freebsd_committer 2020-09-20 14:45:17 UTC
(In reply to PauAmma from comment #5)

To clarify a bit for portmgr:
Since this involves lame, which is a bit problematic, I'd like portmgr@ to have a look as well, just in case.
Thank you!
Comment 7 PauAmma freebsd_triage 2020-12-13 01:07:23 UTC
Anything else I should do to move this forward?
Comment 8 PauAmma freebsd_triage 2021-01-09 21:22:15 UTC
The patch for this has been gathering dust for 4 months now. Is there something I should be doing to move this forward? Maybe refresh the patch? Does portmgr@ care to opine?
Comment 9 Bernhard Froehlich freebsd_committer 2021-02-07 16:05:54 UTC
In the meantime packages for lame are available so adding a dependency on lame should be fine.
Comment 10 PauAmma freebsd_triage 2021-02-07 19:48:39 UTC
(In reply to Bernhard Froehlich from comment #9)
Thanks for letting me know! I checked and lame is now available as a package indeed. So I'll make sure that dependency is present in all ports listed above (which it should be already - that's how I got the list of affected packages in the first place) and close as OBE if it is.
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2021-02-08 02:10:07 UTC
@Reporter Since audio/lame is now packaged (since ports r554970), does the proposal change to adding dependencies to individual ports where necessary?
Comment 12 PauAmma freebsd_triage 2021-02-08 03:01:22 UTC
(In reply to Kubilay Kocak from comment #11)
Either that or close it as OBE if they already are marked as dependencies, which they probably are given where I got the list from but I want to check first.
Comment 13 Thomas Zander freebsd_committer 2021-03-15 17:19:22 UTC
(In reply to PauAmma from comment #12)

Anything left to do here?
Comment 14 PauAmma freebsd_triage 2021-03-15 19:45:04 UTC
(In reply to Thomas Zander from comment #13)
Still haven't had time to check, and I'm not sure when I will. Unless someone else can check meanwhile and provide a definitive answer, I'll probably mark this OBE within the next month or so.