Bug 242546 - [REVIVE] science/orthanc: Orthanc is a DICOM server for healthcare and medical research
Summary: [REVIVE] science/orthanc: Orthanc is a DICOM server for healthcare and medica...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Loïc Bartoletti
URL:
Keywords: feature, needs-qa
Depends on:
Blocks: 242547 242548 242549 242552
  Show dependency treegraph
 
Reported: 2019-12-10 15:28 UTC by Frank Scholl
Modified: 2020-09-04 05:21 UTC (History)
3 users (show)

See Also:


Attachments
.shar of the orthanc port. (8.07 KB, text/plain)
2019-12-10 15:28 UTC, Frank Scholl
no flags Details
orthanc-1.6.1 (11.75 KB, text/plain)
2020-05-25 06:08 UTC, Frank Scholl
no flags Details
Diff / the latest version of science/ortanc (14.30 KB, patch)
2020-06-19 20:59 UTC, Thierry Thomas
maintainer.freebsd: maintainer-approval+
Details | Diff
orthanc-1.7.1 (10.57 KB, text/plain)
2020-06-24 15:19 UTC, Frank Scholl
no flags Details
orthanc-1.7.2 (9.09 KB, text/plain)
2020-08-04 16:05 UTC, Frank Scholl
no flags Details
orthanc-1.7.2_1 (8.17 KB, text/plain)
2020-08-07 14:02 UTC, Frank Scholl
no flags Details
Diff / the latest version of science/ortanc (orthanc-1.7.2_1, diff based on r471825) (9.87 KB, patch)
2020-08-10 09:34 UTC, Frank Scholl
no flags Details | Diff
Diff / the latest version of science/ortanc (orthanc-1.7.2_1, diff based on r544608) (12.49 KB, patch)
2020-08-10 09:39 UTC, Frank Scholl
no flags Details | Diff
orthanc patch fixed (11.53 KB, patch)
2020-09-04 05:21 UTC, Loïc Bartoletti
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Scholl 2019-12-10 15:28:15 UTC
Created attachment 209831 [details]
.shar of the orthanc port.

Port expired on 2018-06-06, fixed and cleaned up the build, updated descriptions, willing to maintain the port from now on.

https://www.freshports.org/science/orthanc
Comment 1 Frank Scholl 2020-05-25 06:08:40 UTC
Created attachment 214830 [details]
orthanc-1.6.1

Update to Orthanc 1.6.1, made portlint happy, builds in poudriere
Comment 2 Thierry Thomas freebsd_committer 2020-06-19 20:56:32 UTC
- This is a resurrection: attached is the diff against the latest version.
	(the 1rst line is kept)

- you don´t have to list the same dependency several time, e.g.
LIB_DEPENDS=	libboost_atomic.so:devel/boost-libs \
		libboost_chrono.so:devel/boost-libs \
		libboost_date_time.so:devel/boost-libs \
		libboost_filesystem.so:devel/boost-libs \
		libboost_locale.so:devel/boost-libs \
		libboost_regex.so:devel/boost-libs \
		libboost_system.so:devel/boost-libs \
		libboost_thread.so:devel/boost-libs \
  should be replaced by
LIB_DEPENDS=	libboost_thread.so:devel/boost-libs

- it uses libiconv
  => you should add iconv to USES=

- you registered a dependency to lua51, but if lua53 is installed, OrthancRecoverCompressedFile is linked to liblua-5.3.so
Comment 3 Thierry Thomas freebsd_committer 2020-06-19 20:59:05 UTC
Created attachment 215799 [details]
Diff / the latest version of science/ortanc

Reminder: also update MOVED and science/Makefile.
Comment 4 Frank Scholl 2020-06-24 15:16:57 UTC
orthanc-1.7.1

- update to Orthanc 1.7.1
- cleaned up dependency list
- updated USES= to contain iconv and lua without a specific version number
- tested build in poudriere

Attached the new .shar of this port. Am I supposed to provide a .diff if when resurrecting an old port and should I provide .diffs for MOVED and the category's Makefile as well?
Comment 5 Frank Scholl 2020-06-24 15:19:08 UTC
Created attachment 215907 [details]
orthanc-1.7.1

orthanc-1.7.1
Comment 6 Thierry Thomas freebsd_committer 2020-06-24 15:32:37 UTC
(In reply to Frank Scholl from comment #4)

The remark about the diff, MOVED and science/Makefile is just a reminder for the committer, you are note supposed to provide it.

Thanks for your new patch, I'll check it ASAP.
Comment 7 Frank Scholl 2020-06-25 16:59:41 UTC
Just wanted to let you now that all dependent ports from the block list are updated to build with Orthanc 1.7.1.
Comment 8 Thierry Thomas freebsd_committer 2020-06-26 16:43:28 UTC
Unfortunately it fails, because some files and directories are produced under $STAGEDIR but never installed:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: /wrkdirs/usr/ports/science/orthanc/work/.build/%%LUA_LIBDIR%%ConnectivityChecks.so
Error: Orphaned: /wrkdirs/usr/ports/science/orthanc/work/.build/%%LUA_LIBDIR%%ConnectivityChecks.so.%%PORTVERSION%%
Error: Orphaned: @dir /wrkdirs/usr/ports/science/orthanc/work/.build
Error: Orphaned: @dir /wrkdirs/usr/ports/science/orthanc/work
Error: Orphaned: @dir /wrkdirs/usr/ports/science/orthanc
Error: Orphaned: @dir /wrkdirs/usr/ports/science
Error: Orphaned: @dir /wrkdirs/usr/ports
Error: Orphaned: @dir /wrkdirs/usr
Error: Orphaned: @dir /wrkdirs
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: etc/rc.d/orthanc
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/science/orthanc
=>> Error: check-plist failures detected
build of science/orthanc | orthanc-1.7.1 ended at Fri Jun 26 18:31:58 CEST 2020

If this ConnectivityChecks.so is required, you should moved it under a usable directory.

And I guess that the working directory might be removed.
Comment 9 Frank Scholl 2020-06-29 13:58:09 UTC
Thank you. Looking into that for this port and taking care for the other dependent ports as well (make check-orphaned and make check-plist).
Comment 10 Frank Scholl 2020-07-13 08:26:34 UTC
I am still looking into this, coming back with the next patch when it is ready.
Comment 11 Frank Scholl 2020-08-04 16:05:25 UTC
Created attachment 217005 [details]
orthanc-1.7.2

Updated orthanc to 1.7.2, the .so you mentioned before is not built anymore (and removed from pkg-plist). Cleaned up pkg-plist in respect to USE_RC_SUBR as well (rc script from files should not be mentioned in pkg-plist).
Comment 12 Thierry Thomas freebsd_committer 2020-08-04 17:18:00 UTC
Put back to pool, sorry.
Comment 13 Frank Scholl 2020-08-06 09:02:11 UTC
(In reply to Thierry Thomas from comment #12)

Thank you for your assistance so far!
Comment 14 Frank Scholl 2020-08-07 14:02:53 UTC
Created attachment 217069 [details]
orthanc-1.7.2_1

Fixed the to be patched files. Tested with poudriere.

Question regarding USE_RC_SUBR: how should a maintainer deal with an rc script? Should it be included in pkg-plist (so people can grep through to find installed files as mentioned in the handbook) or is it ok to just use USE_RC_SUBR (like I did now)?

Depending on your answer regarding this question I will provide an updated .shar.
Comment 15 Frank Scholl 2020-08-10 09:00:55 UTC
(In reply to Thierry Thomas from comment #3)
+
The maintainer e-mail address is correct.
Comment 16 Frank Scholl 2020-08-10 09:34:46 UTC
Created attachment 217125 [details]
Diff / the latest version of science/ortanc (orthanc-1.7.2_1, diff based on r471825)

To make it easier for the next one taking over this bug, I added a .diff like thierry's.
Comment 17 Frank Scholl 2020-08-10 09:39:46 UTC
Created attachment 217126 [details]
Diff / the latest version of science/ortanc (orthanc-1.7.2_1, diff based on r544608)

This diff is based on today's head (r544608), including:

- removed orthanc from MOVED
- added orthanc to science/Makefile
- all files from the attached .shar

I hope this helps to resurrect science/orthanc. If there is anything I am supposed to prepare, please let me know.
Comment 18 Mark Linimon freebsd_committer freebsd_triage 2020-08-15 05:29:23 UTC
^Triage: restore state to Open because it has been unassigned.
Comment 19 Loïc Bartoletti freebsd_committer 2020-09-04 05:21:24 UTC
Created attachment 217732 [details]
orthanc patch fixed

Are you sure that the diff is the good one? DOS2UNIX doesn't found "CMakeLists.txt", is it ${WRKSRC}/OrthancServer/CMAkeLists.txt?

I fixed your patch for CMakeLists.txt, it must have the path as patch-OrthancServer_Resources_Configuration.json (see https://www.freebsd.org/doc/en/books/porters-handbook/book.html#slow-patch)