Created attachment 209831 [details] .shar of the orthanc port. Port expired on 2018-06-06, fixed and cleaned up the build, updated descriptions, willing to maintain the port from now on. https://www.freshports.org/science/orthanc
Created attachment 214830 [details] orthanc-1.6.1 Update to Orthanc 1.6.1, made portlint happy, builds in poudriere
- This is a resurrection: attached is the diff against the latest version. (the 1rst line is kept) - you don´t have to list the same dependency several time, e.g. LIB_DEPENDS= libboost_atomic.so:devel/boost-libs \ libboost_chrono.so:devel/boost-libs \ libboost_date_time.so:devel/boost-libs \ libboost_filesystem.so:devel/boost-libs \ libboost_locale.so:devel/boost-libs \ libboost_regex.so:devel/boost-libs \ libboost_system.so:devel/boost-libs \ libboost_thread.so:devel/boost-libs \ should be replaced by LIB_DEPENDS= libboost_thread.so:devel/boost-libs - it uses libiconv => you should add iconv to USES= - you registered a dependency to lua51, but if lua53 is installed, OrthancRecoverCompressedFile is linked to liblua-5.3.so
Created attachment 215799 [details] Diff / the latest version of science/ortanc Reminder: also update MOVED and science/Makefile.
orthanc-1.7.1 - update to Orthanc 1.7.1 - cleaned up dependency list - updated USES= to contain iconv and lua without a specific version number - tested build in poudriere Attached the new .shar of this port. Am I supposed to provide a .diff if when resurrecting an old port and should I provide .diffs for MOVED and the category's Makefile as well?
Created attachment 215907 [details] orthanc-1.7.1 orthanc-1.7.1
(In reply to Frank Scholl from comment #4) The remark about the diff, MOVED and science/Makefile is just a reminder for the committer, you are note supposed to provide it. Thanks for your new patch, I'll check it ASAP.
Just wanted to let you now that all dependent ports from the block list are updated to build with Orthanc 1.7.1.
Unfortunately it fails, because some files and directories are produced under $STAGEDIR but never installed: ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: /wrkdirs/usr/ports/science/orthanc/work/.build/%%LUA_LIBDIR%%ConnectivityChecks.so Error: Orphaned: /wrkdirs/usr/ports/science/orthanc/work/.build/%%LUA_LIBDIR%%ConnectivityChecks.so.%%PORTVERSION%% Error: Orphaned: @dir /wrkdirs/usr/ports/science/orthanc/work/.build Error: Orphaned: @dir /wrkdirs/usr/ports/science/orthanc/work Error: Orphaned: @dir /wrkdirs/usr/ports/science/orthanc Error: Orphaned: @dir /wrkdirs/usr/ports/science Error: Orphaned: @dir /wrkdirs/usr/ports Error: Orphaned: @dir /wrkdirs/usr Error: Orphaned: @dir /wrkdirs ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: etc/rc.d/orthanc ===> Error: Plist issues found. *** Error code 1 Stop. make: stopped in /usr/ports/science/orthanc =>> Error: check-plist failures detected build of science/orthanc | orthanc-1.7.1 ended at Fri Jun 26 18:31:58 CEST 2020 If this ConnectivityChecks.so is required, you should moved it under a usable directory. And I guess that the working directory might be removed.
Thank you. Looking into that for this port and taking care for the other dependent ports as well (make check-orphaned and make check-plist).
I am still looking into this, coming back with the next patch when it is ready.
Created attachment 217005 [details] orthanc-1.7.2 Updated orthanc to 1.7.2, the .so you mentioned before is not built anymore (and removed from pkg-plist). Cleaned up pkg-plist in respect to USE_RC_SUBR as well (rc script from files should not be mentioned in pkg-plist).
Put back to pool, sorry.
(In reply to Thierry Thomas from comment #12) Thank you for your assistance so far!
Created attachment 217069 [details] orthanc-1.7.2_1 Fixed the to be patched files. Tested with poudriere. Question regarding USE_RC_SUBR: how should a maintainer deal with an rc script? Should it be included in pkg-plist (so people can grep through to find installed files as mentioned in the handbook) or is it ok to just use USE_RC_SUBR (like I did now)? Depending on your answer regarding this question I will provide an updated .shar.
(In reply to Thierry Thomas from comment #3) + The maintainer e-mail address is correct.
Created attachment 217125 [details] Diff / the latest version of science/ortanc (orthanc-1.7.2_1, diff based on r471825) To make it easier for the next one taking over this bug, I added a .diff like thierry's.
Created attachment 217126 [details] Diff / the latest version of science/ortanc (orthanc-1.7.2_1, diff based on r544608) This diff is based on today's head (r544608), including: - removed orthanc from MOVED - added orthanc to science/Makefile - all files from the attached .shar I hope this helps to resurrect science/orthanc. If there is anything I am supposed to prepare, please let me know.
^Triage: restore state to Open because it has been unassigned.
Created attachment 217732 [details] orthanc patch fixed Are you sure that the diff is the good one? DOS2UNIX doesn't found "CMakeLists.txt", is it ${WRKSRC}/OrthancServer/CMAkeLists.txt? I fixed your patch for CMakeLists.txt, it must have the path as patch-OrthancServer_Resources_Configuration.json (see https://www.freebsd.org/doc/en/books/porters-handbook/book.html#slow-patch)