Bug 242580 - net-im/6cord: Unbreak on aarch64
Summary: net-im/6cord: Unbreak on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL:
Keywords:
Depends on:
Blocks: 242312
  Show dependency treegraph
 
Reported: 2019-12-11 13:24 UTC by Dmitri Goutnik
Modified: 2019-12-11 14:33 UTC (History)
1 user (show)

See Also:
vulcan: maintainer-feedback+


Attachments
6cord-9.5_2.patch (2.27 KB, patch)
2019-12-11 13:24 UTC, Dmitri Goutnik
vulcan: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2019-12-11 13:24:33 UTC
Created attachment 209865 [details]
6cord-9.5_2.patch

===>  Building 6cord from .
# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128

http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518685_s355218/logs/errors/6cord-9.5_1.log

Unbreak by updating golang.org/x/sys to 33540a1f6037 which adds support for freebsd/arm64. Upstream PR: https://gitlab.com/diamondburned/6cord/merge_requests/21

Tested on 12.1-STABLE/arm64 and 12.1-RELEASE/amd64.
Comment 1 Lewis Cook 2019-12-11 13:33:04 UTC
Good work, approved. :)
Comment 2 Lewis Cook 2019-12-11 13:47:20 UTC
On a similar note, I think it's best to merge this patch first then I'll update bug#242365 to avoid any conflicts.
Comment 3 commit-hook freebsd_committer 2019-12-11 14:10:06 UTC
A commit references this bug:

Author: dmgk
Date: Wed Dec 11 14:09:42 UTC 2019
New revision: 519805
URL: https://svnweb.freebsd.org/changeset/ports/519805

Log:
  net-im/6cord: Unbreak on aarch64

  ===>  Building 6cord from .
  # golang.org/x/sys/unix
  vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128

  http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518685_s355218/logs/errors/6cord-9.5_1.log

  Unbreak by updating golang.org/x/sys to 33540a1f6037 which adds support for freebsd/arm64.
  Upstream PR: https://gitlab.com/diamondburned/6cord/merge_requests/21

  PR:		242580
  Approved by:	Lewis Cook <vulcan@wired.sh> (maintainer)

Changes:
  head/net-im/6cord/Makefile
  head/net-im/6cord/distinfo