Bug 242581 - security/lego: Unbreak on aarch64
Summary: security/lego: Unbreak on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL:
Keywords:
Depends on:
Blocks: 242312
  Show dependency treegraph
 
Reported: 2019-12-11 14:05 UTC by Dmitri Goutnik
Modified: 2019-12-12 12:01 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (matt)


Attachments
lego-3.2.0_1.patch (3.38 KB, patch)
2019-12-11 14:05 UTC, Dmitri Goutnik
dmgk: maintainer-approval? (matt)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2019-12-11 14:05:31 UTC
Created attachment 209866 [details]
lego-3.2.0_1.patch

===>  Building lego from ./cmd/lego
# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128

http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518685_s355218/logs/errors/lego-3.2.0.log

Unbreak by updating golang.org/x/sys to 33540a1f6037 and golang.org/x/net to 83d349e8ac1a which adds support for freebsd/arm64.

Upstream PRs:
https://github.com/go-acme/lego/pull/1019
https://github.com/miekg/dns/pull/1048

Tested on 12.1-STABLE/arm64 and 12.1-RELEASE/amd64.
Comment 1 Matthew Horan 2019-12-11 15:47:11 UTC
Looks good to me.
Comment 2 commit-hook freebsd_committer 2019-12-12 12:01:02 UTC
A commit references this bug:

Author: dmgk
Date: Thu Dec 12 12:00:56 UTC 2019
New revision: 519860
URL: https://svnweb.freebsd.org/changeset/ports/519860

Log:
  security/lego: Unbreak on aarch64

  ===>  Building lego from ./cmd/lego
  # golang.org/x/sys/unix
  vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128

  http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518685_s355218/logs/errors/lego-3.2.0.log

  Unbreak by updating golang.org/x/sys to 33540a1f6037 and golang.org/x/net to
  83d349e8ac1a which adds support for freebsd/arm64.

  PR:		242581
  Approved by:	Matthew Horan <matt@matthoran.com> (maintainer)

Changes:
  head/security/lego/Makefile
  head/security/lego/distinfo