Bug 242586 - [MAINTAINER] www/rss-bridge: update to 2019-12-01
Summary: [MAINTAINER] www/rss-bridge: update to 2019-12-01
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2019-12-11 21:24 UTC by Oleg Sidorkin
Modified: 2019-12-28 17:40 UTC (History)
0 users

See Also:


Attachments
patch to update www/rss-bridge to 2019-12-01 release (obtained by svn diff) (7.23 KB, patch)
2019-12-11 21:24 UTC, Oleg Sidorkin
no flags Details | Diff
Improved patch (7.93 KB, patch)
2019-12-27 23:36 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2019-12-11 21:24:55 UTC
Created attachment 209877 [details]
patch to update www/rss-bridge to 2019-12-01 release (obtained by svn diff)

Attached patch contains update of www/rss-bridge port to 2019-12-01 release
Comment 1 Automation User 2019-12-11 21:38:29 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/102429496
Comment 2 Dmitry Marakasov freebsd_committer 2019-12-27 23:36:58 UTC
Created attachment 210269 [details]
Improved patch

How about this improved patch?

Use options helpers, simplify the port and fix version handling.
Comment 3 Oleg Sidorkin 2019-12-28 09:15:38 UTC
(In reply to Dmitry Marakasov from comment #2)
Thanks for contributing.

I'm ok with this patch (however it's better to drop %%SQLITE%% prefix from pkg-plist entry also).
Comment 4 Dmitry Marakasov freebsd_committer 2019-12-28 17:36:42 UTC
(In reply to Oleg Sidorkin from comment #3)
No, this is intentional. %%SQLITE%% controls whether SQLiteCache.php gets into the package depending on the option, so the behavior of not installing SQLiteCache.php when SQLITE is disabled is retained. My patch just removes needless duplication of that logic with COPY_SKIP_OPT.
Comment 5 commit-hook freebsd_committer 2019-12-28 17:38:13 UTC
A commit references this bug:

Author: amdmi3
Date: Sat Dec 28 17:37:17 UTC 2019
New revision: 521226
URL: https://svnweb.freebsd.org/changeset/ports/521226

Log:
  - Update to 2019-12-01
  - Simplify the port

  PR:		242586
  Submitted by:	osidorkin@gmail.com (maintainer)

Changes:
  head/www/rss-bridge/Makefile
  head/www/rss-bridge/distinfo
  head/www/rss-bridge/pkg-plist