Bug 242591 - sysutils/node_exporter: go-modules build has no version
Summary: sysutils/node_exporter: go-modules build has no version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitri Goutnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-12 04:18 UTC by xavier.l+bsd
Modified: 2019-12-13 11:57 UTC (History)
2 users (show)

See Also:
ports: maintainer-feedback+


Attachments
Update path of version variable (548 bytes, patch)
2019-12-12 04:32 UTC, xavier.l+bsd
dmgk: maintainer-approval? (ports)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description xavier.l+bsd 2019-12-12 04:18:52 UTC
With the update to go-modules, the path where the version variables are located changed, see https://github.com/prometheus/node_exporter/commit/becca1275c77ffab31ec7082b3bd9ba9382a6c1a#diff-07d111372e64f2921c7241dc8f97fb04L8-R12.

Patch incoming.
Comment 1 xavier.l+bsd 2019-12-12 04:32:00 UTC
Created attachment 209884 [details]
Update path of version variable

This patch removes the vendor section from the path to the version variables populated at build time.
Comment 2 commit-hook freebsd_committer 2019-12-13 11:55:54 UTC
A commit references this bug:

Author: dmgk
Date: Fri Dec 13 11:55:50 UTC 2019
New revision: 520023
URL: https://svnweb.freebsd.org/changeset/ports/520023

Log:
  sysutils/node_exporter: Fix version variable path

  PR:		242591
  Submitted by:	xavier.l+bsd@magnax.ca
  Approved by:	jevonearth <ports@ecadlabs.com> (maintainer)

Changes:
  head/sysutils/node_exporter/Makefile
Comment 3 Dmitri Goutnik freebsd_committer 2019-12-13 11:57:00 UTC
Committed, thanks!