Bug 242644 - lang/gcc*: Enable PLUGINS by default
Summary: lang/gcc*: Enable PLUGINS by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords: feature
Depends on:
Blocks:
 
Reported: 2019-12-15 08:56 UTC by Tobias Kortkamp
Modified: 2020-11-28 10:45 UTC (History)
1 user (show)

See Also:
gerald: maintainer-feedback+


Attachments
gcc-plugins.diff (1.81 KB, patch)
2019-12-15 08:56 UTC, Tobias Kortkamp
tobik: maintainer-approval? (gerald)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-12-15 08:56:11 UTC
Created attachment 209965 [details]
gcc-plugins.diff

AFAICT there is no reason why it should not be on by default and having it on
by default unlocks the possibility to properly package and maintain GCC plugins
without custom builds of lang/gcc*, e.g., for security/afl++.
Comment 1 Tobias Kortkamp freebsd_committer 2019-12-22 05:59:16 UTC
Remove needs-qa. QA was always fine.
Comment 2 Gerald Pfeifer freebsd_committer 2019-12-23 11:28:33 UTC
Thank you. 

I'll include those changes when updating to the snapshots of
lang/gcc10-devel and lang/gcc9-devel from around mid-December,
which should both happen this week.

Let's let this cook for some two weeks and then consider how
to go about lang/gcc9?  I'll also respond to the e-mail thread
on svn-ports-all@freebsd.org.
Comment 3 commit-hook freebsd_committer 2019-12-27 04:14:34 UTC
A commit references this bug:

Author: gerald
Date: Fri Dec 27 04:13:58 UTC 2019
New revision: 520964
URL: https://svnweb.freebsd.org/changeset/ports/520964

Log:
  Update to the 20191215 snapshot of GCC 10.0.0.

  Enable GCC plugins support by default. [1]

  PR:		242644 [1]
  Submitted by: 	tobik [1]

Changes:
  head/lang/gcc10-devel/Makefile
  head/lang/gcc10-devel/distinfo
Comment 4 commit-hook freebsd_committer 2019-12-28 08:53:38 UTC
A commit references this bug:

Author: gerald
Date: Sat Dec 28 08:53:04 UTC 2019
New revision: 521207
URL: https://svnweb.freebsd.org/changeset/ports/521207

Log:
  Update to the 20191214 snapshot of GCC 9.2.1.

  Enable GCC plugins support by default. [1]

  PR:		242644 [1]
  Submitted by: 	tobik [1]

Changes:
  head/lang/gcc9-devel/Makefile
  head/lang/gcc9-devel/distinfo
Comment 5 commit-hook freebsd_committer 2020-01-18 08:46:29 UTC
A commit references this bug:

Author: gerald
Date: Sat Jan 18 08:45:54 UTC 2020
New revision: 523406
URL: https://svnweb.freebsd.org/changeset/ports/523406

Log:
  Backport (part of) r521207 | gerald | 2019-12-28 from lang/gcc9-devel:

    Enable GCC plugins support by default.

  PR:		242644
  Submitted by: 	tobik
  Differential Revision:	https://reviews.freebsd.org/D22292

Changes:
  head/lang/gcc9/Makefile
Comment 6 Gerald Pfeifer freebsd_committer 2020-01-18 09:09:54 UTC
With that we have covered GCC 10 (-devel only for now) and GCC 9 (-devel
and release), so have addressed everything, right?

Thanks for suggesting this change.
Comment 7 Tobias Kortkamp freebsd_committer 2020-01-18 12:38:24 UTC
(In reply to Gerald Pfeifer from comment #6)
Yes, that should be it AFAIAC. Thanks! I'll turn on the GCC option in afl++
after the next round of package builds.
Comment 8 commit-hook freebsd_committer 2020-11-17 08:49:17 UTC
A commit references this bug:

Author: gerald
Date: Tue Nov 17 08:49:04 UTC 2020
New revision: 555542
URL: https://svnweb.freebsd.org/changeset/ports/555542

Log:
  Update to the 20201113 snapshot of GCC 9.3.1.

  This brings two backports for the x86 back end, two for the Fortran
  front end, and one for libstdc++.

  Fold the PLUGINS option, which has been on by default, into standard
  behavior and remove that option.  It has not been causing any issues
  since we enabled it 11 months ago, nor measurable overhead. [1]

  PR:		242644 [1]

Changes:
  head/lang/gcc9-devel/Makefile
  head/lang/gcc9-devel/distinfo
Comment 9 commit-hook freebsd_committer 2020-11-18 20:30:31 UTC
A commit references this bug:

Author: gerald
Date: Wed Nov 18 20:29:58 UTC 2020
New revision: 555665
URL: https://svnweb.freebsd.org/changeset/ports/555665

Log:
  Update to the 20201114 snapshot of GCC 10.2.1.

  This brings two backports for GOMP, one for aarch64, two for powerpc (nee
  rs6000) and two for x86, one for the tree optimizers, two for the C front
  end and three for C++ and Fortran each, plus half a dozen for libstdc++.

  Forward port part of r555542 | gerald | 2020-11-17 from lang/gcc9-devel:

    Fold the PLUGINS option, which has been on by default, into standard
    behavior and remove that option.  It has not been causing any issues
    since we enabled it 11 months ago, nor measurable overhead. [1]

  PR:		242644 [1]

Changes:
  head/lang/gcc10-devel/Makefile
  head/lang/gcc10-devel/distinfo
Comment 10 commit-hook freebsd_committer 2020-11-20 19:54:01 UTC
A commit references this bug:

Author: gerald
Date: Fri Nov 20 19:53:49 UTC 2020
New revision: 555778
URL: https://svnweb.freebsd.org/changeset/ports/555778

Log:
  Update to the 20201115 snapshot of GCC 11.0.0.

  Forward port part of r555542 | gerald | 2020-11-17 from lang/gcc9-devel:

    Fold the PLUGINS option, which has been on by default, into standard
    behavior and remove that option.  It has not been causing any issues
    since we enabled it 11 months ago, nor measurable overhead. [1]

  PR:		242644 [1]

Changes:
  head/lang/gcc11-devel/Makefile
  head/lang/gcc11-devel/distinfo
Comment 11 commit-hook freebsd_committer 2020-11-28 10:45:28 UTC
A commit references this bug:

Author: gerald
Date: Sat Nov 28 10:45:21 UTC 2020
New revision: 556486
URL: https://svnweb.freebsd.org/changeset/ports/556486

Log:
  Back port part of r555665 | gerald | 2020-11-18 from lang/gcc10-devel:

    Forward port part of r555542 | gerald | 2020-11-17 from lang/gcc9-devel:

      Fold the PLUGINS option, which has been on by default, into standard
      behavior and remove that option.  It has not been causing any issues
      since we enabled it 11 months ago, nor measurable overhead.

  PR:		242644

Changes:
  head/lang/gcc10/Makefile