Bug 242644 - lang/gcc*: Enable PLUGINS by default
Summary: lang/gcc*: Enable PLUGINS by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords: feature
Depends on:
Blocks:
 
Reported: 2019-12-15 08:56 UTC by Tobias Kortkamp
Modified: 2020-01-18 12:38 UTC (History)
1 user (show)

See Also:
gerald: maintainer-feedback+


Attachments
gcc-plugins.diff (1.81 KB, patch)
2019-12-15 08:56 UTC, Tobias Kortkamp
tobik: maintainer-approval? (gerald)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-12-15 08:56:11 UTC
Created attachment 209965 [details]
gcc-plugins.diff

AFAICT there is no reason why it should not be on by default and having it on
by default unlocks the possibility to properly package and maintain GCC plugins
without custom builds of lang/gcc*, e.g., for security/afl++.
Comment 1 Tobias Kortkamp freebsd_committer 2019-12-22 05:59:16 UTC
Remove needs-qa. QA was always fine.
Comment 2 Gerald Pfeifer freebsd_committer 2019-12-23 11:28:33 UTC
Thank you. 

I'll include those changes when updating to the snapshots of
lang/gcc10-devel and lang/gcc9-devel from around mid-December,
which should both happen this week.

Let's let this cook for some two weeks and then consider how
to go about lang/gcc9?  I'll also respond to the e-mail thread
on svn-ports-all@freebsd.org.
Comment 3 commit-hook freebsd_committer 2019-12-27 04:14:34 UTC
A commit references this bug:

Author: gerald
Date: Fri Dec 27 04:13:58 UTC 2019
New revision: 520964
URL: https://svnweb.freebsd.org/changeset/ports/520964

Log:
  Update to the 20191215 snapshot of GCC 10.0.0.

  Enable GCC plugins support by default. [1]

  PR:		242644 [1]
  Submitted by: 	tobik [1]

Changes:
  head/lang/gcc10-devel/Makefile
  head/lang/gcc10-devel/distinfo
Comment 4 commit-hook freebsd_committer 2019-12-28 08:53:38 UTC
A commit references this bug:

Author: gerald
Date: Sat Dec 28 08:53:04 UTC 2019
New revision: 521207
URL: https://svnweb.freebsd.org/changeset/ports/521207

Log:
  Update to the 20191214 snapshot of GCC 9.2.1.

  Enable GCC plugins support by default. [1]

  PR:		242644 [1]
  Submitted by: 	tobik [1]

Changes:
  head/lang/gcc9-devel/Makefile
  head/lang/gcc9-devel/distinfo
Comment 5 commit-hook freebsd_committer 2020-01-18 08:46:29 UTC
A commit references this bug:

Author: gerald
Date: Sat Jan 18 08:45:54 UTC 2020
New revision: 523406
URL: https://svnweb.freebsd.org/changeset/ports/523406

Log:
  Backport (part of) r521207 | gerald | 2019-12-28 from lang/gcc9-devel:

    Enable GCC plugins support by default.

  PR:		242644
  Submitted by: 	tobik
  Differential Revision:	https://reviews.freebsd.org/D22292

Changes:
  head/lang/gcc9/Makefile
Comment 6 Gerald Pfeifer freebsd_committer 2020-01-18 09:09:54 UTC
With that we have covered GCC 10 (-devel only for now) and GCC 9 (-devel
and release), so have addressed everything, right?

Thanks for suggesting this change.
Comment 7 Tobias Kortkamp freebsd_committer 2020-01-18 12:38:24 UTC
(In reply to Gerald Pfeifer from comment #6)
Yes, that should be it AFAIAC. Thanks! I'll turn on the GCC option in afl++
after the next round of package builds.